[Chromecast] Add kDisableES3GLContext to command line on Cast builds.

[Chromecast] Add kDisableES3GLContext to command line on Cast builds.

ES3 support was recently enabled by default:
  https://codereview.chromium.org/2354423002

This causes the GPU process to fail at startup. Disable ES3 GL context
with a command-line flag on Cast builds.

BUG=659395
Committed: https://crrev.com/a6fcc0127ab9a0f25a5cc0e46e657438be4037d7
Cr-Commit-Position: refs/heads/master@{#427589}

[slan, 2016-10-05 21:20:21]

slan@chromium.org changed reviewers:
+ alokp@chromium.org, halliwell@chromium.org

[slan, 2016-10-05 21:20:22]

I don't have much context on ES3, but this change is needed to make various Cast
devices work. PTAL.

[slan, 2016-10-05 21:20:39]

The CQ bit was checked by slan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-05 21:21:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-05 21:36:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-05 21:36:34]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[slan, 2016-10-05 21:53:36]

The CQ bit was checked by slan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-05 21:54:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-05 22:15:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-05 22:15:55]

Dry run: This issue passed the CQ dry run.

[slan, 2016-10-06 16:20:28]

ping!

[halliwell, 2016-10-06 18:22:41]

On 2016/10/06 16:20:28, slan wrote:
> ping!

lgtm, but can you file a ticket (feel free to assign to me) to follow up on
this?  I just don't have time to look closely right now :)

[slan, 2016-10-26 00:23:29]

Description was changed from

==========
[Chromecast] Add kDisableES3GLContext to command line on Cast builds.

ES3 support was recently enabled by default:
  https://codereview.chromium.org/2354423002

This causes the GPU process to fail at startup. Disable ES3 GL context
with a command-line flag on Cast builds.

BUG=
==========

to

==========
[Chromecast] Add kDisableES3GLContext to command line on Cast builds.

ES3 support was recently enabled by default:
  https://codereview.chromium.org/2354423002

This causes the GPU process to fail at startup. Disable ES3 GL context
with a command-line flag on Cast builds.

BUG=659395
==========

[slan, 2016-10-26 00:27:05]

+jbauman for content/browser/gpu

PTAL!

[slan, 2016-10-26 00:27:53]

slan@chromium.org changed reviewers:
+ kbr@chromium.org

[slan, 2016-10-26 00:27:54]

Ken, PTAL at content/browser/gpu! Thanks!

[slan, 2016-10-26 00:28:11]

The CQ bit was checked by slan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-26 00:29:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Ken Russell (switch to Gerrit), 2016-10-26 00:29:51]

LGTM

Did you check and verify that you couldn't do this with a new entry in
src/gpu/config/gpu_driver_bug_list_json.cc ?

[commit-bot: I haz the power, 2016-10-26 01:37:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-26 01:37:10]

Dry run: This issue passed the CQ dry run.

[halliwell, 2016-10-26 02:28:09]

On 2016/10/26 00:29:51, Ken Russell wrote:
> LGTM
> 
> Did you check and verify that you couldn't do this with a new entry in
> src/gpu/config/gpu_driver_bug_list_json.cc ?

We haven't had time to look at this properly at all - super slammed with
hardware release dates right now :(
Plan is to treat this as a temporary workaround and follow up afterwards on bug
659395.

[slan, 2016-10-26 02:31:32]

On 2016/10/26 02:28:09, halliwell wrote:
> On 2016/10/26 00:29:51, Ken Russell wrote:
> > LGTM
> > 
> > Did you check and verify that you couldn't do this with a new entry in
> > src/gpu/config/gpu_driver_bug_list_json.cc ?
> 
> We haven't had time to look at this properly at all - super slammed with
> hardware release dates right now :(
> Plan is to treat this as a temporary workaround and follow up afterwards on
bug
> 659395.

+1, the switch is only to unblock our builds from crashing. The bug will contain
the proper work.

[slan, 2016-10-26 02:31:39]

The CQ bit was checked by slan@chromium.org

[slan, 2016-10-26 02:31:40]

The patchset sent to the CQ was uploaded after l-g-t-m from
halliwell@chromium.org
Link to the patchset: https://codereview.chromium.org/2387333004/#ps40001
(title: "TODO added. Also, it actually works now.")

[commit-bot: I haz the power, 2016-10-26 02:32:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-26 04:10:32]

Description was changed from

==========
[Chromecast] Add kDisableES3GLContext to command line on Cast builds.

ES3 support was recently enabled by default:
  https://codereview.chromium.org/2354423002

This causes the GPU process to fail at startup. Disable ES3 GL context
with a command-line flag on Cast builds.

BUG=659395
==========

to

==========
[Chromecast] Add kDisableES3GLContext to command line on Cast builds.

ES3 support was recently enabled by default:
  https://codereview.chromium.org/2354423002

This causes the GPU process to fail at startup. Disable ES3 GL context
with a command-line flag on Cast builds.

BUG=659395
==========

[commit-bot: I haz the power, 2016-10-26 04:10:34]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-10-26 04:13:46]

Description was changed from

==========
[Chromecast] Add kDisableES3GLContext to command line on Cast builds.

ES3 support was recently enabled by default:
  https://codereview.chromium.org/2354423002

This causes the GPU process to fail at startup. Disable ES3 GL context
with a command-line flag on Cast builds.

BUG=659395
==========

to

==========
[Chromecast] Add kDisableES3GLContext to command line on Cast builds.

ES3 support was recently enabled by default:
  https://codereview.chromium.org/2354423002

This causes the GPU process to fail at startup. Disable ES3 GL context
with a command-line flag on Cast builds.

BUG=659395

Committed: https://crrev.com/a6fcc0127ab9a0f25a5cc0e46e657438be4037d7
Cr-Commit-Position: refs/heads/master@{#427589}
==========

[commit-bot: I haz the power, 2016-10-26 04:13:47]

Patchset 3 (id:??) landed as
https://crrev.com/a6fcc0127ab9a0f25a5cc0e46e657438be4037d7
Cr-Commit-Position: refs/heads/master@{#427589}