Index: content/browser/media/android/media_player_renderer.cc |
diff --git a/content/browser/media/android/media_player_renderer.cc b/content/browser/media/android/media_player_renderer.cc |
index 62ae926689cf23d0c23dadeb745b8dde1174aacc..d99383c31fda34b7e0502ffda1ed69172812bae7 100644 |
--- a/content/browser/media/android/media_player_renderer.cc |
+++ b/content/browser/media/android/media_player_renderer.cc |
@@ -81,6 +81,14 @@ void MediaPlayerRenderer::StartPlayingFrom(base::TimeDelta time) { |
media_player_->Start(); |
media_player_->SeekTo(time); |
+ |
+ // There is a chicken-and-egg problem between WMPI waiting until we have |
+ // enough data to send a playback_rate > 0, and for HLS files to trigger a |
tguilbert
2016/10/06 02:11:39
I will re-word this comment.
tguilbert
2016/10/11 18:54:33
Done.
|
+ // call to OnBufferingUpdate. Always return BUFFERING_HAVE_ENOUGH here, since |
+ // MediaPlayer manages its own buffering and will pause internally if ever it |
+ // runs out of data. |
+ // TODO(tguilbert): Investigate the effect of this call on UMAs. |
+ renderer_client_->OnBufferingStateChange(media::BUFFERING_HAVE_ENOUGH); |
} |
void MediaPlayerRenderer::SetPlaybackRate(double playback_rate) { |
@@ -182,15 +190,7 @@ void MediaPlayerRenderer::OnPlaybackComplete(int player_id) { |
void MediaPlayerRenderer::OnMediaInterrupted(int player_id) {} |
-void MediaPlayerRenderer::OnBufferingUpdate(int player_id, int percentage) { |
- // As per Android documentation, |percentage| actually indicates "percentage |
- // buffered or played". E.g. if we are at 50% playback and have 1% |
- // buffered, |percentage| will be equal to 51. |
- // |
- // MediaPlayer manages its own buffering and will pause internally if ever it |
- // runs out of data. Therefore, we can always return BUFFERING_HAVE_ENOUGH. |
- renderer_client_->OnBufferingStateChange(media::BUFFERING_HAVE_ENOUGH); |
-} |
+void MediaPlayerRenderer::OnBufferingUpdate(int player_id, int percentage) {} |
void MediaPlayerRenderer::OnSeekComplete(int player_id, |
const base::TimeDelta& current_time) {} |