Register MediaPlayerRenderer service

content/browser/media/android/media_player_renderer.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/media/android/media_player_renderer.h"
 
 #include <memory>
 
 #include "content/browser/android/scoped_surface_request_manager.h"
 #include "content/browser/media/android/media_resource_getter_impl.h"
@@ skipping 63 matching lines @@
 }
 
 void MediaPlayerRenderer::StartPlayingFrom(base::TimeDelta time) {
   // MediaPlayerBridge's Start() is idempotent, except when it has encountered
   // an error (in which case, calling Start() again is logged as a new error).
   if (has_error_)
     return;
 
   media_player_->Start();
   media_player_->SeekTo(time);
+
+  // There is a chicken-and-egg problem between WMPI waiting until we have
+  // enough data to send a playback_rate > 0, and for HLS files to trigger a

[tguilbert, 2016/10/06 02:11:39]

I will re-word this comment.

[tguilbert, 2016/10/11 18:54:33]

Done.

+  // call to OnBufferingUpdate. Always return BUFFERING_HAVE_ENOUGH here, since
+  // MediaPlayer manages its own buffering and will pause internally if ever it
+  // runs out of data.
+  // TODO(tguilbert): Investigate the effect of this call on UMAs.
+  renderer_client_->OnBufferingStateChange(media::BUFFERING_HAVE_ENOUGH);
 }
 
 void MediaPlayerRenderer::SetPlaybackRate(double playback_rate) {
   if (has_error_)
     return;
 
   if (playback_rate == 0) {
     media_player_->Pause(true);
   } else {
     // MediaPlayerBridge's Start() is idempotent.
@@ skipping 81 matching lines @@
     renderer_client_->OnDurationChange(duration);
   }
 }
 
 void MediaPlayerRenderer::OnPlaybackComplete(int player_id) {
   renderer_client_->OnEnded();
 }
 
 void MediaPlayerRenderer::OnMediaInterrupted(int player_id) {}
 
-void MediaPlayerRenderer::OnBufferingUpdate(int player_id, int percentage) {
-  // As per Android documentation, |percentage| actually indicates "percentage
-  // buffered or played". E.g. if we are at 50% playback and have 1%
-  // buffered, |percentage| will be equal to 51.
-  //
-  // MediaPlayer manages its own buffering and will pause internally if ever it
-  // runs out of data. Therefore, we can always return BUFFERING_HAVE_ENOUGH.
-  renderer_client_->OnBufferingStateChange(media::BUFFERING_HAVE_ENOUGH);
-}
+void MediaPlayerRenderer::OnBufferingUpdate(int player_id, int percentage) {}
 
 void MediaPlayerRenderer::OnSeekComplete(int player_id,
                                          const base::TimeDelta& current_time) {}
 
 void MediaPlayerRenderer::OnError(int player_id, int error) {
   // Some errors are forwarded to the MediaPlayerListener, but are of no
   // importance to us. Ignore these errors, which are reported as error 0 by
   // MediaPlayerListener.
   if (!error)
     return;
@@ skipping 39 matching lines @@
 void MediaPlayerRenderer::CancelScopedSurfaceRequest() {
   if (!surface_request_token_)
     return;
 
   ScopedSurfaceRequestManager::GetInstance()->UnregisterScopedSurfaceRequest(
       surface_request_token_);
   surface_request_token_ = base::UnguessableToken();
 }
 
 }  // namespace content