Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3423)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandler.java

Issue 2387293005: Change external link handling policy for CCTs (Closed)
Patch Set: Ted's styling suggestions Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandler.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandler.java b/chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandler.java
index 3524e7b1e43a1bf290ef3af4e726b789c3386935..aa8298001e127c721d9b6cdd52be8d4799e74655 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandler.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandler.java
@@ -206,11 +206,7 @@ public class ExternalNavigationHandler {
// http://crbug/424029 : Need to stay in Chrome for an intent heading explicitly to Chrome.
if (params.getRedirectHandler() != null) {
TabRedirectHandler handler = params.getRedirectHandler();
- if (handler.isFromCustomTabIntent()) {
- // http://crbug.com/613667 : Custom tabs forbids external navigation for the first
- // url, unless the first url is a redirect.
- if (!params.isRedirect()) return OverrideUrlLoadingResult.NO_OVERRIDE;
- } else if (handler.shouldStayInChrome(isExternalProtocol)
+ if (handler.shouldStayInChrome(isExternalProtocol)
|| handler.shouldNotOverrideUrlLoading()) {
return OverrideUrlLoadingResult.NO_OVERRIDE;
}

Powered by Google App Engine
This is Rietveld 408576698