chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabIntentDataProvider.java - Issue 2387293005: Change external link handling policy for CCTs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabIntentDataProvider.java

Issue 2387293005: Change external link handling policy for CCTs (Closed)

Patch Set: Ted's styling suggestions Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/ChromeFeatureList.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandler.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabIntentDataProvider.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabIntentDataProvider.java b/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabIntentDataProvider.java

index 931d6578ad9fbc7ffbd23b464fff0924e4dff26e..2453fe3ca4207eb55958d8f636f2c75d1ca7ea3e 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabIntentDataProvider.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabIntentDataProvider.java

@@ -60,6 +60,11 @@ public class CustomTabIntentDataProvider {

public static final String EXTRA_IS_MEDIA_VIEWER =

"org.chromium.chrome.browser.customtabs.IS_MEDIA_VIEWER";

+ //TODO(yusufo): Move this to CustomTabsIntent.

+ /** Signals custom tabs to favor sending initial urls to external handler apps if possible. */

+ public static final String EXTRA_SEND_TO_EXTERNAL_DEFAULT_HANDLER =

+ "android.support.customtabs.extra.SEND_TO_EXTERNAL_HANDLER";

private static final int MAX_CUSTOM_MENU_ITEMS = 5;

private static final String ANIMATION_BUNDLE_PREFIX =

Build.VERSION.SDK_INT >= Build.VERSION_CODES.M ? "android:activity." : "android:";