Manually remove many instances of a comma quirk arising from the reformat.

Manually remove many instances of a comma quirk arising from the reformat.

This removes many of the lines consisting only of a comma after the Blink
reformat. About half remain, though, because they are the result of
trailing elements of an initializer or argument list being within preprocessor
guards (most commonly ENABLE(ASSERT)), and there does not seem to be a nice
way of formatting those in Chromium style.

BUG=563793
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Committed: https://crrev.com/906bce9979d00f93f0137851faeac638e100beb4
Cr-Commit-Position: refs/heads/master@{#423166}

[jbroman, 2016-10-04 21:20:06]

Description was changed from

==========
Manually remove many instances of a comma quirk arising from the reformat.

This removes many of the lines consisting only of a comma after the Blink
reformat. About half remain, though, because they are the result of
trailing elements of an initializer or argument list being within preprocessor
guards (most commonly ENABLE(ASSERT)), and there does not seem to be a nice
way of formatting those in Chromium style.
==========

to

==========
Manually remove many instances of a comma quirk arising from the reformat.

This removes many of the lines consisting only of a comma after the Blink
reformat. About half remain, though, because they are the result of
trailing elements of an initializer or argument list being within preprocessor
guards (most commonly ENABLE(ASSERT)), and there does not seem to be a nice
way of formatting those in Chromium style.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[jbroman, 2016-10-04 21:20:09]

The CQ bit was checked by jbroman@chromium.org to run a CQ dry run

[jbroman, 2016-10-04 21:20:18]

Description was changed from

==========
Manually remove many instances of a comma quirk arising from the reformat.

This removes many of the lines consisting only of a comma after the Blink
reformat. About half remain, though, because they are the result of
trailing elements of an initializer or argument list being within preprocessor
guards (most commonly ENABLE(ASSERT)), and there does not seem to be a nice
way of formatting those in Chromium style.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Manually remove many instances of a comma quirk arising from the reformat.

This removes many of the lines consisting only of a comma after the Blink
reformat. About half remain, though, because they are the result of
trailing elements of an initializer or argument list being within preprocessor
guards (most commonly ENABLE(ASSERT)), and there does not seem to be a nice
way of formatting those in Chromium style.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[commit-bot: I haz the power, 2016-10-04 21:21:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jbroman, 2016-10-04 21:21:21]

jbroman@chromium.org changed reviewers:
+ thakis@chromium.org

[jbroman, 2016-10-04 21:21:22]

WDYT (trybots-willing, of course)

[commit-bot: I haz the power, 2016-10-04 23:06:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-04 23:06:45]

Dry run: This issue passed the CQ dry run.

[haraken, 2016-10-05 01:03:00]

LGTM

[jbroman, 2016-10-05 01:09:28]

The CQ bit was checked by jbroman@chromium.org

[commit-bot: I haz the power, 2016-10-05 01:09:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Nico, 2016-10-05 01:14:34]

The CQ bit was unchecked by thakis@chromium.org

[Nico, 2016-10-05 01:20:09]

Nice, thanks! lgtm.

I have one comment (the 2nd); dunno if you want to do this here or in a
follow-up. (I unchecked cq so you see this mail; feel free to re-check it if
you'd rather land this and do a follow-up.)

https://codereview.chromium.org/2387263004/diff/1/third_party/WebKit/Source/b...
File third_party/WebKit/Source/bindings/core/v8/DOMDataStore.h (right):

https://codereview.chromium.org/2387263004/diff/1/third_party/WebKit/Source/b...
third_party/WebKit/Source/bindings/core/v8/DOMDataStore.h:56: // We never use
|m_wrapperMap| when it's the main world.
Oh, looks like I missed this one when I reflowed comments in bindings/ :-(

https://codereview.chromium.org/2387263004/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/css/MediaQueryEvaluator.cpp (right):

https://codereview.chromium.org/2387263004/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/css/MediaQueryEvaluator.cpp:78: false),  //
Doesn't matter when we have m_frame and m_style.
Maybe move this comment above the : line, then the initializer will look better

https://codereview.chromium.org/2387263004/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/editing/iterators/WordAwareIterator.cpp
(right):

https://codereview.chromium.org/2387263004/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/editing/iterators/WordAwareIterator.cpp:32: // So
we consider the first chunk from the text iterator.
Yup, like so :-)

https://codereview.chromium.org/2387263004/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/layout/svg/LayoutSVGInlineText.cpp (right):

https://codereview.chromium.org/2387263004/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/svg/LayoutSVGInlineText.cpp:219: 0,  //
length, will be set below if non-zero.
this looks a bit weird (but i don't know how to do this better either)

[Nico, 2016-10-05 01:20:56]

Description was changed from

==========
Manually remove many instances of a comma quirk arising from the reformat.

This removes many of the lines consisting only of a comma after the Blink
reformat. About half remain, though, because they are the result of
trailing elements of an initializer or argument list being within preprocessor
guards (most commonly ENABLE(ASSERT)), and there does not seem to be a nice
way of formatting those in Chromium style.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Manually remove many instances of a comma quirk arising from the reformat.

This removes many of the lines consisting only of a comma after the Blink
reformat. About half remain, though, because they are the result of
trailing elements of an initializer or argument list being within preprocessor
guards (most commonly ENABLE(ASSERT)), and there does not seem to be a nice
way of formatting those in Chromium style.

BUG=563793

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[jbroman, 2016-10-05 13:38:41]

The CQ bit was checked by jbroman@chromium.org

[jbroman, 2016-10-05 13:38:42]

The patchset sent to the CQ was uploaded after l-g-t-m from
haraken@chromium.org, thakis@chromium.org
Link to the patchset: https://codereview.chromium.org/2387263004/#ps20001
(title: "merge with master; thakis nit")

[commit-bot: I haz the power, 2016-10-05 13:38:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jbroman, 2016-10-05 13:42:00]

jbroman@chromium.org changed reviewers:
+ haraken@chromium.org

[jbroman, 2016-10-05 13:42:01]

https://codereview.chromium.org/2387263004/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/css/MediaQueryEvaluator.cpp (right):

https://codereview.chromium.org/2387263004/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/css/MediaQueryEvaluator.cpp:78: false),  //
Doesn't matter when we have m_frame and m_style.
On 2016/10/05 at 01:20:08, Nico wrote:
> Maybe move this comment above the : line, then the initializer will look
better

Done.

https://codereview.chromium.org/2387263004/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/editing/iterators/WordAwareIterator.cpp
(right):

https://codereview.chromium.org/2387263004/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/editing/iterators/WordAwareIterator.cpp:32: // So
we consider the first chunk from the text iterator.
On 2016/10/05 at 01:20:08, Nico wrote:
> Yup, like so :-)

Acknowledged.

https://codereview.chromium.org/2387263004/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/layout/svg/LayoutSVGInlineText.cpp (right):

https://codereview.chromium.org/2387263004/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/svg/LayoutSVGInlineText.cpp:219: 0,  //
length, will be set below if non-zero.
On 2016/10/05 at 01:20:08, Nico wrote:
> this looks a bit weird (but i don't know how to do this better either)

Acknowledged.

[commit-bot: I haz the power, 2016-10-05 15:25:21]

Description was changed from

==========
Manually remove many instances of a comma quirk arising from the reformat.

This removes many of the lines consisting only of a comma after the Blink
reformat. About half remain, though, because they are the result of
trailing elements of an initializer or argument list being within preprocessor
guards (most commonly ENABLE(ASSERT)), and there does not seem to be a nice
way of formatting those in Chromium style.

BUG=563793

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Manually remove many instances of a comma quirk arising from the reformat.

This removes many of the lines consisting only of a comma after the Blink
reformat. About half remain, though, because they are the result of
trailing elements of an initializer or argument list being within preprocessor
guards (most commonly ENABLE(ASSERT)), and there does not seem to be a nice
way of formatting those in Chromium style.

BUG=563793

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[commit-bot: I haz the power, 2016-10-05 15:25:23]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-10-05 15:27:58]

Description was changed from

==========
Manually remove many instances of a comma quirk arising from the reformat.

This removes many of the lines consisting only of a comma after the Blink
reformat. About half remain, though, because they are the result of
trailing elements of an initializer or argument list being within preprocessor
guards (most commonly ENABLE(ASSERT)), and there does not seem to be a nice
way of formatting those in Chromium style.

BUG=563793

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Manually remove many instances of a comma quirk arising from the reformat.

This removes many of the lines consisting only of a comma after the Blink
reformat. About half remain, though, because they are the result of
trailing elements of an initializer or argument list being within preprocessor
guards (most commonly ENABLE(ASSERT)), and there does not seem to be a nice
way of formatting those in Chromium style.

BUG=563793

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Committed: https://crrev.com/906bce9979d00f93f0137851faeac638e100beb4
Cr-Commit-Position: refs/heads/master@{#423166}
==========

[commit-bot: I haz the power, 2016-10-05 15:28:00]

Patchset 2 (id:??) landed as
https://crrev.com/906bce9979d00f93f0137851faeac638e100beb4
Cr-Commit-Position: refs/heads/master@{#423166}

[dmazzoni, 2016-10-06 06:11:51]

dmazzoni@chromium.org changed reviewers:
+ dmazzoni@chromium.org

[dmazzoni, 2016-10-06 06:11:51]

lgtm for modules/accessibility