Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Side by Side Diff: third_party/WebKit/Source/core/html/HTMLPlugInElement.cpp

Issue 2387263004: Manually remove many instances of a comma quirk arising from the reformat. (Closed)
Patch Set: merge with master; thakis nit Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /** 1 /**
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2000 Stefan Schimanski (1Stein@gmx.de) 4 * (C) 2000 Stefan Schimanski (1Stein@gmx.de)
5 * Copyright (C) 2004, 2005, 2006 Apple Computer, Inc. 5 * Copyright (C) 2004, 2005, 2006 Apple Computer, Inc.
6 * 6 *
7 * This library is free software; you can redistribute it and/or 7 * This library is free software; you can redistribute it and/or
8 * modify it under the terms of the GNU Library General Public 8 * modify it under the terms of the GNU Library General Public
9 * License as published by the Free Software Foundation; either 9 * License as published by the Free Software Foundation; either
10 * version 2 of the License, or (at your option) any later version. 10 * version 2 of the License, or (at your option) any later version.
(...skipping 58 matching lines...) Expand 10 before | Expand all | Expand 10 after
69 }; 69 };
70 70
71 } // anonymous namespace 71 } // anonymous namespace
72 72
73 HTMLPlugInElement::HTMLPlugInElement( 73 HTMLPlugInElement::HTMLPlugInElement(
74 const QualifiedName& tagName, 74 const QualifiedName& tagName,
75 Document& doc, 75 Document& doc,
76 bool createdByParser, 76 bool createdByParser,
77 PreferPlugInsForImagesOption preferPlugInsForImagesOption) 77 PreferPlugInsForImagesOption preferPlugInsForImagesOption)
78 : HTMLFrameOwnerElement(tagName, doc), 78 : HTMLFrameOwnerElement(tagName, doc),
79 m_isDelayingLoadEvent(false) 79 m_isDelayingLoadEvent(false),
80 // m_needsWidgetUpdate(!createdByParser) allows HTMLObjectElement to delay 80 // m_needsWidgetUpdate(!createdByParser) allows HTMLObjectElement to delay
81 // widget updates until after all children are parsed. For HTMLEmbedElemen t 81 // widget updates until after all children are parsed. For HTMLEmbedElemen t
82 // this delay is unnecessary, but it is simpler to make both classes share 82 // this delay is unnecessary, but it is simpler to make both classes share
83 // the same codepath in this class. 83 // the same codepath in this class.
84 ,
85 m_needsWidgetUpdate(!createdByParser), 84 m_needsWidgetUpdate(!createdByParser),
86 m_shouldPreferPlugInsForImages(preferPlugInsForImagesOption == 85 m_shouldPreferPlugInsForImages(preferPlugInsForImagesOption ==
87 ShouldPreferPlugInsForImages) {} 86 ShouldPreferPlugInsForImages) {}
88 87
89 HTMLPlugInElement::~HTMLPlugInElement() { 88 HTMLPlugInElement::~HTMLPlugInElement() {
90 DCHECK(!m_pluginWrapper); // cleared in detachLayoutTree() 89 DCHECK(!m_pluginWrapper); // cleared in detachLayoutTree()
91 DCHECK(!m_isDelayingLoadEvent); 90 DCHECK(!m_isDelayingLoadEvent);
92 } 91 }
93 92
94 DEFINE_TRACE(HTMLPlugInElement) { 93 DEFINE_TRACE(HTMLPlugInElement) {
(...skipping 545 matching lines...) Expand 10 before | Expand all | Expand 10 after
640 639
641 void HTMLPlugInElement::lazyReattachIfNeeded() { 640 void HTMLPlugInElement::lazyReattachIfNeeded() {
642 if (!useFallbackContent() && needsWidgetUpdate() && layoutObject() && 641 if (!useFallbackContent() && needsWidgetUpdate() && layoutObject() &&
643 !isImageType()) { 642 !isImageType()) {
644 lazyReattachIfAttached(); 643 lazyReattachIfAttached();
645 setPersistedPluginWidget(nullptr); 644 setPersistedPluginWidget(nullptr);
646 } 645 }
647 } 646 }
648 647
649 } // namespace blink 648 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698