Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Issue 2387263002: Rename MojoShellContext -> ServiceManagerContext. (Closed)

Created:
4 years, 2 months ago by Ben Goodger (Google)
Modified:
4 years, 2 months ago
CC:
Aaron Boodman, abarth-chromium, chromium-reviews, darin (slow to review), darin-cc_chromium.org, jam, jochen+watch_chromium.org, mlamouri+watch-content_chromium.org, Peter Beverloo, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename MojoShellContext -> ServiceManagerContext. R=rockot@chromium.org,tsepez@chromium.org Committed: https://crrev.com/ff4616342b5f638b1f51f9cdda03dd7e2507cfb0 Cr-Commit-Position: refs/heads/master@{#423522}

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Patch Set 4 : . #

Patch Set 5 : . #

Patch Set 6 : . #

Patch Set 7 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+176 lines, -803 lines) Patch
M content/browser/BUILD.gn View 2 chunks +4 lines, -4 lines 0 comments Download
M content/browser/browser_child_process_host_impl.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/browser_main_loop.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/browser_main_loop.cc View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M content/browser/gpu/gpu_process_host.cc View 1 1 chunk +1 line, -1 line 0 comments Download
D content/browser/mojo/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
D content/browser/mojo/merge_dictionary.h View 1 chunk +0 lines, -21 lines 0 comments Download
D content/browser/mojo/merge_dictionary.cc View 1 chunk +0 lines, -43 lines 0 comments Download
D content/browser/mojo/merge_dictionary_unittest.cc View 1 chunk +0 lines, -73 lines 0 comments Download
D content/browser/mojo/mojo_shell_context.h View 1 chunk +0 lines, -39 lines 0 comments Download
D content/browser/mojo/mojo_shell_context.cc View 1 chunk +0 lines, -308 lines 0 comments Download
M content/browser/mojo_sandbox_browsertest.cc View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_process_host_browsertest.cc View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
A + content/browser/service_manager/OWNERS View 0 chunks +-1 lines, --1 lines 0 comments Download
A + content/browser/service_manager/merge_dictionary.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + content/browser/service_manager/merge_dictionary.cc View 1 chunk +1 line, -1 line 0 comments Download
A + content/browser/service_manager/merge_dictionary_unittest.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
A + content/browser/service_manager/service_manager_context.h View 3 chunks +10 lines, -10 lines 0 comments Download
A + content/browser/service_manager/service_manager_context.cc View 7 chunks +9 lines, -8 lines 0 comments Download
M content/browser/service_worker/service_worker_version_unittest.cc View 1 2 3 4 6 chunks +10 lines, -10 lines 0 comments Download
M content/browser/utility_process_host_impl.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/utility_process_host_impl_browsertest.cc View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/utility_process_mojo_client_browsertest.cc View 1 2 3 4 3 chunks +3 lines, -3 lines 0 comments Download
D content/public/test/test_mojo_app.h View 1 chunk +0 lines, -56 lines 0 comments Download
D content/public/test/test_mojo_app.cc View 1 chunk +0 lines, -62 lines 0 comments Download
D content/public/test/test_mojo_service.mojom View 1 chunk +0 lines, -24 lines 0 comments Download
D content/public/test/test_mojo_shell_context.h View 1 chunk +0 lines, -31 lines 0 comments Download
D content/public/test/test_mojo_shell_context.cc View 1 chunk +0 lines, -16 lines 0 comments Download
A + content/public/test/test_service.h View 2 chunks +16 lines, -16 lines 0 comments Download
A + content/public/test/test_service.cc View 2 chunks +13 lines, -14 lines 0 comments Download
A + content/public/test/test_service.mojom View 1 chunk +1 line, -1 line 0 comments Download
A content/public/test/test_service_manager_context.h View 1 chunk +31 lines, -0 lines 0 comments Download
A content/public/test/test_service_manager_context.cc View 1 chunk +16 lines, -0 lines 0 comments Download
M content/public/test/test_utils.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/public/test/test_utils.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M content/renderer/render_thread_impl_browsertest.cc View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M content/shell/browser/content_shell_renderer_manifest_overlay.json View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M content/shell/browser/content_shell_utility_manifest_overlay.json View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M content/shell/browser/shell_content_browser_client.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M content/shell/renderer/shell_content_renderer_client.cc View 1 2 3 4 4 chunks +13 lines, -13 lines 0 comments Download
M content/shell/utility/shell_content_utility_client.cc View 4 chunks +13 lines, -13 lines 0 comments Download
M content/test/BUILD.gn View 4 chunks +6 lines, -6 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 36 (28 generated)
Ken Rockot(use gerrit already)
RS LGTM
4 years, 2 months ago (2016-10-03 23:12:16 UTC) #1
Ken Rockot(use gerrit already)
NOT LGTM WRONG CL
4 years, 2 months ago (2016-10-03 23:15:41 UTC) #2
Ben Goodger (Google)
On 2016/10/03 23:15:41, Ken Rockot wrote: > NOT LGTM WRONG CL I can haz lgtm?
4 years, 2 months ago (2016-10-05 22:24:25 UTC) #21
Tom Sepez
lgtm
4 years, 2 months ago (2016-10-05 22:28:47 UTC) #24
Ken Rockot(use gerrit already)
lgtm
4 years, 2 months ago (2016-10-05 22:30:24 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2387263002/120001
4 years, 2 months ago (2016-10-06 14:21:40 UTC) #33
commit-bot: I haz the power
Committed patchset #7 (id:120001)
4 years, 2 months ago (2016-10-06 14:27:54 UTC) #34
commit-bot: I haz the power
4 years, 2 months ago (2016-10-06 14:29:47 UTC) #36
Message was sent while issue was closed.
Patchset 7 (id:??) landed as
https://crrev.com/ff4616342b5f638b1f51f9cdda03dd7e2507cfb0
Cr-Commit-Position: refs/heads/master@{#423522}

Powered by Google App Engine
This is Rietveld 408576698