Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Issue 2398783002: Rename a bunch of Mojo Application stuff to reference Services. (Closed)

Created:
4 years, 2 months ago by Ben Goodger (Google)
Modified:
4 years, 2 months ago
CC:
Aaron Boodman, abarth-chromium, aboxhall+watch_chromium.org, achuith+watch_chromium.org, alemate+watch_chromium.org, alokp+watch_chromium.org, anandc+watch-blimp_chromium.org, bgoldman+watch-blimp_chromium.org, chromium-reviews, creis+watch_chromium.org, danakj+watch_chromium.org, darin (slow to review), darin-cc_chromium.org, davemoore+watch_chromium.org, dcheng, dmazzoni+watch_chromium.org, dtrainor+watch-blimp_chromium.org, dtseng+watch_chromium.org, gcasto+watch-blimp_chromium.org, halliwell+watch_chromium.org, jam, jbauman+watch_chromium.org, je_julie, jessicag+watch-blimp_chromium.org, jochen+watch_chromium.org, kalyank, khushalsagar+watch-blimp_chromium.org, kmarshall+watch-blimp_chromium.org, lcwu+watch_chromium.org, lethalantidote+watch-blimp_chromium.org, maniscalco+watch-blimp_chromium.org, marcinjb+watch-blimp_chromium.org, mlamouri+watch-content_chromium.org, nasko+codewatch_chromium.org, nektar+watch_chromium.org, nona+watch_chromium.org, nyquist+watch-blimp_chromium.org, oshima+watch_chromium.org, perumaal+watch-blimp_chromium.org, Peter Beverloo, piman+watch_chromium.org, qsr+mojo_chromium.org, sadrul, scf+watch-blimp_chromium.org, shaktisahu+watch-blimp_chromium.org, shuchen+watch_chromium.org, sievers+watch_chromium.org, sriramsr+watch-blimp_chromium.org, steimel+watch-blimp_chromium.org, James Su, tfarina, viettrungluu+watch_chromium.org, wjmaclean, yusukes+watch_chromium.org, yuzo+watch_chromium.org, yzshen+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename a bunch of Mojo Application stuff to reference Services. . MojoShellConnection -> ServiceManagerConnection . MojoChildConnection -> ChildConnection . EmbeddedApplicationRunner -> EmbeddedServiceRunner . *MojoApplication* -> *Service* R=rockot@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation Committed: https://crrev.com/d32292b72806e2905866f86202d2ff9cedeffc58 Cr-Commit-Position: refs/heads/master@{#423757}

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Patch Set 4 : . #

Patch Set 5 : . #

Patch Set 6 : . #

Patch Set 7 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+691 lines, -1849 lines) Patch
M ash/common/wm_shell.h View 1 chunk +1 line, -1 line 0 comments Download
M blimp/engine/app/blimp_content_browser_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chrome_browser_main.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chrome_browser_main.cc View 2 chunks +8 lines, -7 lines 0 comments Download
M chrome/browser/chrome_browser_main_extra_parts.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chrome_content_browser_client.h View 1 2 3 1 chunk +3 lines, -4 lines 0 comments Download
M chrome/browser/chrome_content_browser_client.cc View 1 2 3 3 chunks +14 lines, -14 lines 0 comments Download
M chrome/browser/chromeos/accessibility/accessibility_manager.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/chrome_interface_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/ash/chrome_shell_delegate.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_mash_shelf_controller.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/ash/system_tray_client.cc View 1 2 3 4 5 6 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/browser_command_controller.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/chrome_browser_main_extra_parts_views.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/chrome_browser_main_extra_parts_views.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/tabs/tab_drag_controller.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/test/base/mash_browser_tests_main.cc View 3 chunks +11 lines, -9 lines 0 comments Download
M chromecast/browser/cast_content_browser_client.h View 1 chunk +1 line, -2 lines 0 comments Download
M chromecast/browser/cast_content_browser_client.cc View 2 chunks +7 lines, -7 lines 0 comments Download
M content/browser/BUILD.gn View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/browser_child_process_host_impl.h View 3 chunks +3 lines, -3 lines 0 comments Download
M content/browser/browser_child_process_host_impl.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M content/browser/browser_context.cc View 6 chunks +53 lines, -46 lines 0 comments Download
M content/browser/browser_main_loop.cc View 2 chunks +5 lines, -3 lines 0 comments Download
M content/browser/compositor/gpu_process_transport_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/frame_host/render_frame_host_impl.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/gpu/gpu_process_host.cc View 1 2 3 5 chunks +6 lines, -6 lines 0 comments Download
M content/browser/ppapi_plugin_process_host.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.h View 1 2 3 3 chunks +5 lines, -4 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 2 3 11 chunks +35 lines, -34 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mus.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/service_manager/service_manager_context.cc View 4 chunks +32 lines, -32 lines 0 comments Download
M content/browser/storage_partition_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/utility_process_host_impl.cc View 1 2 3 2 chunks +3 lines, -3 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M content/child/child_thread_impl.h View 1 2 3 5 chunks +10 lines, -9 lines 0 comments Download
M content/child/child_thread_impl.cc View 1 2 3 4 11 chunks +28 lines, -25 lines 0 comments Download
M content/child/service_factory.h View 2 chunks +4 lines, -4 lines 0 comments Download
M content/child/service_factory.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M content/common/BUILD.gn View 1 2 3 2 chunks +4 lines, -4 lines 0 comments Download
M content/common/in_process_child_thread_params.h View 1 2 3 1 chunk +4 lines, -4 lines 0 comments Download
M content/common/in_process_child_thread_params.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
D content/common/mojo/DEPS View 1 chunk +0 lines, -5 lines 0 comments Download
D content/common/mojo/OWNERS View 1 chunk +0 lines, -5 lines 0 comments Download
D content/common/mojo/embedded_application_runner.h View 1 chunk +0 lines, -64 lines 0 comments Download
D content/common/mojo/embedded_application_runner.cc View 1 chunk +0 lines, -177 lines 0 comments Download
D content/common/mojo/mojo_child_connection.h View 1 chunk +0 lines, -78 lines 0 comments Download
D content/common/mojo/mojo_child_connection.cc View 1 chunk +0 lines, -153 lines 0 comments Download
D content/common/mojo/mojo_shell_connection_impl.h View 1 chunk +0 lines, -82 lines 0 comments Download
D content/common/mojo/mojo_shell_connection_impl.cc View 1 chunk +0 lines, -504 lines 0 comments Download
A + content/common/service_manager/DEPS View 0 chunks +-1 lines, --1 lines 0 comments Download
A + content/common/service_manager/OWNERS View 0 chunks +-1 lines, --1 lines 0 comments Download
A + content/common/service_manager/child_connection.h View 3 chunks +16 lines, -16 lines 0 comments Download
A + content/common/service_manager/child_connection.cc View 4 chunks +6 lines, -6 lines 0 comments Download
A content/common/service_manager/embedded_service_runner.h View 1 chunk +63 lines, -0 lines 0 comments Download
A + content/common/service_manager/embedded_service_runner.cc View 10 chunks +27 lines, -28 lines 0 comments Download
A + content/common/service_manager/service_manager_connection_impl.h View 5 chunks +14 lines, -14 lines 0 comments Download
A + content/common/service_manager/service_manager_connection_impl.cc View 7 chunks +50 lines, -50 lines 0 comments Download
M content/gpu/gpu_child_thread.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M content/gpu/gpu_service_factory.cc View 1 chunk +4 lines, -5 lines 0 comments Download
M content/public/browser/browser_context.h View 2 chunks +10 lines, -10 lines 0 comments Download
M content/public/browser/browser_main_parts.h View 2 chunks +3 lines, -2 lines 0 comments Download
M content/public/browser/content_browser_client.h View 1 2 3 3 chunks +21 lines, -23 lines 0 comments Download
M content/public/browser/content_browser_client.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M content/public/child/child_thread.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/public/common/BUILD.gn View 2 chunks +3 lines, -3 lines 0 comments Download
M content/public/common/connection_filter.h View 1 chunk +3 lines, -3 lines 0 comments Download
D content/public/common/mojo_application_info.h View 1 chunk +0 lines, -50 lines 0 comments Download
D content/public/common/mojo_application_info.cc View 1 chunk +0 lines, -19 lines 0 comments Download
M content/public/common/mojo_channel_switches.h View 1 chunk +1 line, -1 line 0 comments Download
M content/public/common/mojo_channel_switches.cc View 1 chunk +3 lines, -2 lines 0 comments Download
D content/public/common/mojo_shell_connection.h View 1 chunk +0 lines, -145 lines 0 comments Download
A content/public/common/service_info.h View 1 chunk +50 lines, -0 lines 0 comments Download
A + content/public/common/service_info.cc View 1 chunk +4 lines, -7 lines 0 comments Download
A + content/public/common/service_manager_connection.h View 6 chunks +25 lines, -22 lines 0 comments Download
M content/public/common/service_names.h View 1 chunk +5 lines, -5 lines 0 comments Download
M content/public/common/service_names.cc View 1 chunk +15 lines, -15 lines 0 comments Download
M content/public/test/mock_render_thread.h View 1 chunk +1 line, -1 line 0 comments Download
M content/public/test/mock_render_thread.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/public/utility/content_utility_client.h View 3 chunks +3 lines, -4 lines 0 comments Download
M content/renderer/mus/render_widget_window_tree_client_factory.h View 1 chunk +3 lines, -2 lines 0 comments Download
M content/renderer/mus/render_widget_window_tree_client_factory.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M content/renderer/render_frame_impl.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/render_frame_impl.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/render_thread_impl.cc View 1 2 3 6 chunks +7 lines, -7 lines 0 comments Download
M content/renderer/render_thread_impl_browsertest.cc View 1 2 3 3 chunks +7 lines, -6 lines 0 comments Download
M content/renderer/render_widget.cc View 1 2 3 2 chunks +5 lines, -5 lines 0 comments Download
M content/renderer/renderer_main.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/browser/shell_content_browser_client.h View 1 2 3 1 chunk +2 lines, -4 lines 0 comments Download
M content/shell/browser/shell_content_browser_client.cc View 1 2 3 1 chunk +12 lines, -12 lines 0 comments Download
M content/shell/utility/shell_content_utility_client.h View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/utility/shell_content_utility_client.cc View 1 chunk +4 lines, -5 lines 0 comments Download
M content/utility/utility_service_factory.cc View 1 chunk +4 lines, -5 lines 0 comments Download
M services/file/user_id_map.h View 1 chunk +3 lines, -3 lines 0 comments Download
M services/file/user_id_map.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M services/navigation/content_client/browser_main_parts.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M services/navigation/content_client/content_browser_client.h View 1 2 1 chunk +2 lines, -3 lines 0 comments Download
M services/navigation/content_client/content_browser_client.cc View 1 2 2 chunks +8 lines, -7 lines 0 comments Download
M services/navigation/view_impl.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 31 (26 generated)
Ben Goodger (Google)
4 years, 2 months ago (2016-10-05 22:29:51 UTC) #8
Ken Rockot(use gerrit already)
lgtm
4 years, 2 months ago (2016-10-05 22:32:09 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2398783002/120001
4 years, 2 months ago (2016-10-06 21:50:17 UTC) #27
commit-bot: I haz the power
Committed patchset #7 (id:120001)
4 years, 2 months ago (2016-10-07 00:22:45 UTC) #29
commit-bot: I haz the power
4 years, 2 months ago (2016-10-07 00:24:27 UTC) #31
Message was sent while issue was closed.
Patchset 7 (id:??) landed as
https://crrev.com/d32292b72806e2905866f86202d2ff9cedeffc58
Cr-Commit-Position: refs/heads/master@{#423757}

Powered by Google App Engine
This is Rietveld 408576698