Issue 23872026: Intel: Branch reordering and port arm EmitNumberUntagD() Improvement

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23872026: Intel: Branch reordering and port arm EmitNumberUntagD() Improvement (Closed)

Created:
7 years, 3 months ago by oliv

Modified:
7 years, 3 months ago

Reviewers:
Benedikt Meurer

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Intel: Branch reordering and port arm EmitNumberUntagD() Improvement R=bmeurer@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=16714

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+39 lines, -33 lines)			Patch
	M	src/ia32/lithium-codegen-ia32.cc	View	1 2	3 chunks	+18 lines, -16 lines	0 comments	Download
	M	src/x64/lithium-codegen-x64.cc	View	1 2 3	3 chunks	+21 lines, -17 lines	0 comments	Download

Total messages: 6 (0 generated)

Benedikt Meurer

As discussed offline: The ia32 part of your patch is not going to work. The ...

7 years, 3 months ago (2013-09-13 09:48:17 UTC) #2

oliv

On 2013/09/13 09:48:17, Benedikt Meurer wrote: > As discussed offline: The ia32 part of your ...

7 years, 3 months ago (2013-09-13 11:22:48 UTC) #3

Benedikt Meurer

Looks good. Can you apply this cleanup to the ARM version as well?

7 years, 3 months ago (2013-09-13 11:30:11 UTC) #4

oliv

7 years, 3 months ago (2013-09-13 12:01:42 UTC) #6

Message was sent while issue was closed.

Committed patchset #4 manually as r16714 (presubmit successful).