Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(432)

Issue 2387193003: Revert of Assert that only 0-numbered objects are Released() (Closed)

Created:
4 years, 2 months ago by Lei Zhang
Modified:
4 years, 2 months ago
Reviewers:
Tom Sepez
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Revert of Assert that only 0-numbered objects are Released() (patchset #7 id:120001 of https://codereview.chromium.org/2375343004/ ) Reason for revert: Broke PDFExtensionTest when rolling DEPS in Chromium. Original issue's description: > Assert that only 0-numbered objects are Released() > > This condition holds because numbered objects are brute-force > deleted by the indirect object holder, rather than being > released. > > Be careful about recursive deletion, check before advancing, > since we no longer count on Release() doing this for us. > Fix a few tests where the test was violating ownership rules. > > This should be the last step before completely removing Release() > in favor of direct delete everywhere. > > Committed: https://pdfium.googlesource.com/pdfium/+/aba528a362248a54b27a7e9e046e2b65ab83f624 TBR=tsepez@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://pdfium.googlesource.com/pdfium/+/b73c99335bfbd158ad16dd59c9c52396ffd2b54b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -47 lines) Patch
M core/fpdfapi/fpdf_parser/cpdf_array.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/fpdf_parser/cpdf_dictionary.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/fpdf_parser/cpdf_object.cpp View 1 chunk +3 lines, -1 line 0 comments Download
M core/fpdfapi/fpdf_parser/cpdf_object_unittest.cpp View 6 chunks +7 lines, -25 lines 0 comments Download
M core/fpdfapi/fpdf_parser/cpdf_parser.cpp View 4 chunks +23 lines, -14 lines 0 comments Download
M core/fpdfapi/fpdf_parser/cpdf_stream.cpp View 1 chunk +1 line, -5 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Lei Zhang
Created Revert of Assert that only 0-numbered objects are Released()
4 years, 2 months ago (2016-10-04 04:27:57 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2387193003/1
4 years, 2 months ago (2016-10-04 04:28:02 UTC) #3
commit-bot: I haz the power
4 years, 2 months ago (2016-10-04 04:28:10 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/b73c99335bfbd158ad16dd59c9c52396ffd2...

Powered by Google App Engine
This is Rietveld 408576698