Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(440)

Side by Side Diff: core/fpdfapi/fpdf_parser/cpdf_object.cpp

Issue 2387193003: Revert of Assert that only 0-numbered objects are Released() (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 PDFium Authors. All rights reserved. 1 // Copyright 2016 PDFium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com 5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
6 6
7 #include "core/fpdfapi/fpdf_parser/cpdf_object.h" 7 #include "core/fpdfapi/fpdf_parser/cpdf_object.h"
8 8
9 #include <algorithm> 9 #include <algorithm>
10 10
(...skipping 20 matching lines...) Expand all
31 return CloneObjectNonCyclic(true); 31 return CloneObjectNonCyclic(true);
32 } 32 }
33 33
34 CPDF_Object* CPDF_Object::CloneNonCyclic( 34 CPDF_Object* CPDF_Object::CloneNonCyclic(
35 bool bDirect, 35 bool bDirect,
36 std::set<const CPDF_Object*>* pVisited) const { 36 std::set<const CPDF_Object*>* pVisited) const {
37 return Clone(); 37 return Clone();
38 } 38 }
39 39
40 void CPDF_Object::Release() { 40 void CPDF_Object::Release() {
41 CHECK(!m_ObjNum); 41 if (m_ObjNum)
42 return;
43
42 delete this; 44 delete this;
43 } 45 }
44 46
45 CFX_ByteString CPDF_Object::GetString() const { 47 CFX_ByteString CPDF_Object::GetString() const {
46 return CFX_ByteString(); 48 return CFX_ByteString();
47 } 49 }
48 50
49 CFX_WideString CPDF_Object::GetUnicodeText() const { 51 CFX_WideString CPDF_Object::GetUnicodeText() const {
50 return CFX_WideString(); 52 return CFX_WideString();
51 } 53 }
(...skipping 102 matching lines...) Expand 10 before | Expand all | Expand 10 after
154 return nullptr; 156 return nullptr;
155 } 157 }
156 158
157 CPDF_String* CPDF_Object::AsString() { 159 CPDF_String* CPDF_Object::AsString() {
158 return nullptr; 160 return nullptr;
159 } 161 }
160 162
161 const CPDF_String* CPDF_Object::AsString() const { 163 const CPDF_String* CPDF_Object::AsString() const {
162 return nullptr; 164 return nullptr;
163 } 165 }
OLDNEW
« no previous file with comments | « core/fpdfapi/fpdf_parser/cpdf_dictionary.cpp ('k') | core/fpdfapi/fpdf_parser/cpdf_object_unittest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698