Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(344)

Issue 2387123002: Put the signin error's "Learn More" link on its own line. (Closed)

Created:
4 years, 2 months ago by anthonyvd
Modified:
4 years, 2 months ago
CC:
arv+watch_chromium.org, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Put the signin error's "Learn More" link on its own line. BUG=651933 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/472ffbb2e70ef574e784bd1e4ca7d6320342387a Cr-Commit-Position: refs/heads/master@{#422959}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -9 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/signin/signin_error/signin_error.html View 1 chunk +4 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/signin/signin_error_ui.cc View 1 chunk +5 lines, -7 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
anthonyvd
Hi, Can you guys PTAL at this small change that moves the "Learn More" link ...
4 years, 2 months ago (2016-10-03 19:06:41 UTC) #7
tommycli
lgtm
4 years, 2 months ago (2016-10-03 20:39:46 UTC) #8
Roger Tawa OOO till Jul 10th
lgtm
4 years, 2 months ago (2016-10-04 20:21:13 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2387123002/1
4 years, 2 months ago (2016-10-04 20:44:52 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-04 22:15:49 UTC) #12
commit-bot: I haz the power
4 years, 2 months ago (2016-10-04 22:19:30 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/472ffbb2e70ef574e784bd1e4ca7d6320342387a
Cr-Commit-Position: refs/heads/master@{#422959}

Powered by Google App Engine
This is Rietveld 408576698