Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1507)

Unified Diff: chrome/browser/ui/webui/signin/signin_error_ui.cc

Issue 2387123002: Put the signin error's "Learn More" link on its own line. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/resources/signin/signin_error/signin_error.html ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/webui/signin/signin_error_ui.cc
diff --git a/chrome/browser/ui/webui/signin/signin_error_ui.cc b/chrome/browser/ui/webui/signin/signin_error_ui.cc
index e8ddf994cb866f7ae3f23dcc57df0b380391a3ce..76a07a226fdbcd38b983be62644e51ab7df8785b 100644
--- a/chrome/browser/ui/webui/signin/signin_error_ui.cc
+++ b/chrome/browser/ui/webui/signin/signin_error_ui.cc
@@ -97,23 +97,21 @@ SigninErrorUI::SigninErrorUI(content::WebUI* web_ui,
DCHECK(!existing_name.empty());
source->AddString(
"signinErrorMessage",
- l10n_util::GetStringFUTF16(
- IDS_SIGNIN_ERROR_LEARN_MORE_LINK,
- l10n_util::GetStringFUTF16(IDS_SYNC_USER_NAME_IN_USE_BY_ERROR,
- existing_name)));
+ l10n_util::GetStringFUTF16(IDS_SYNC_USER_NAME_IN_USE_BY_ERROR,
+ existing_name));
// Elide the existing name for the switch user button label.
existing_name =
gfx::TruncateString(existing_name, 10, gfx::CHARACTER_BREAK);
} else {
- source->AddString("signinErrorMessage",
- l10n_util::GetStringFUTF16(
- IDS_SIGNIN_ERROR_LEARN_MORE_LINK, last_login_result));
+ source->AddString("signinErrorMessage", last_login_result);
}
// Add button label strings.
source->AddString("signinErrorSwitchLabel",
l10n_util::GetStringFUTF16(
IDS_SIGNIN_ERROR_SWITCH_BUTTON_LABEL, existing_name));
+ source->AddLocalizedString("signinErrorLearnMore",
+ IDS_SIGNIN_ERROR_LEARN_MORE_LINK);
source->AddLocalizedString("signinErrorCloseLabel",
IDS_SIGNIN_ERROR_CLOSE_BUTTON_LABEL);
source->AddLocalizedString("signinErrorOkLabel",
« no previous file with comments | « chrome/browser/resources/signin/signin_error/signin_error.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698