Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(521)

Unified Diff: content/browser/renderer_host/render_process_host_impl.h

Issue 2387113004: Better bad message reporting from IO thread (Closed)
Patch Set: cleanup Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/render_process_host_impl.h
diff --git a/content/browser/renderer_host/render_process_host_impl.h b/content/browser/renderer_host/render_process_host_impl.h
index 305cda947cb9206025766ce62c1f355a90eda254..e1c34e63fc382995b266a30c26ae336072fd6860 100644
--- a/content/browser/renderer_host/render_process_host_impl.h
+++ b/content/browser/renderer_host/render_process_host_impl.h
@@ -121,7 +121,7 @@ class CONTENT_EXPORT RenderProcessHostImpl
void RemoveRoute(int32_t routing_id) override;
void AddObserver(RenderProcessHostObserver* observer) override;
void RemoveObserver(RenderProcessHostObserver* observer) override;
- void ShutdownForBadMessage() override;
+ void ShutdownForBadMessage(CrashReportMode crash_report_mode) override;
void WidgetRestored() override;
void WidgetHidden() override;
int VisibleWidgetCount() const override;
@@ -378,10 +378,7 @@ class CONTENT_EXPORT RenderProcessHostImpl
base::FilePath GetAecDumpFilePathWithExtensions(const base::FilePath& file);
#endif
- static void OnMojoError(
- base::WeakPtr<RenderProcessHostImpl> process,
- scoped_refptr<base::SingleThreadTaskRunner> task_runner,
- const std::string& error);
+ static void OnMojoError(int render_process_id, const std::string& error);
template <typename InterfaceType>
using AddInterfaceCallback =

Powered by Google App Engine
This is Rietveld 408576698