Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(337)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: content/browser/media/android/browser_media_session_manager.cc

Issue 2387113004: Better bad message reporting from IO thread (Closed)
Patch Set: cleanup Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« content/browser/bad_message.cc ('K') | « content/browser/bad_message.cc ('k') | content/browser/renderer_host/render_process_host_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/media/android/browser_media_session_manager.cc
diff --git a/content/browser/media/android/browser_media_session_manager.cc b/content/browser/media/android/browser_media_session_manager.cc
index dffee6cdfd7f3719977e6ae927251828a97bbfa6..a16dafb0e4a32ee496dd6240918051845d6023ac 100644
--- a/content/browser/media/android/browser_media_session_manager.cc
+++ b/content/browser/media/android/browser_media_session_manager.cc
@@ -36,7 +36,8 @@ void BrowserMediaSessionManager::OnSetMetadata(
// coming from a known and secure source. It must be processed accordingly.
if (insecure_metadata.has_value() &&
!MediaMetadataSanitizer::CheckSanity(insecure_metadata.value())) {
- render_frame_host_->GetProcess()->ShutdownForBadMessage();
+ render_frame_host_->GetProcess()->ShutdownForBadMessage(
+ RenderProcessHost::CrashReportMode::GENERATE_CRASH_DUMP);
return;
}
« content/browser/bad_message.cc ('K') | « content/browser/bad_message.cc ('k') | content/browser/renderer_host/render_process_host_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698