Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issue 2387113002: reflow comments in public/platform/ (Closed)

Created:
4 years, 2 months ago by Nico
Modified:
4 years, 2 months ago
Reviewers:
dcheng
CC:
chromium-reviews, Yoav Weiss, gavinp+prerender_chromium.org, tzik, mlamouri+watch-blink_chromium.org, dcheng, kinuko+fileapi, nhiroki, feature-media-reviews_chromium.org, dglazkov+blink, eric.carlson_apple.com, blink-reviews, Srirama, blink-reviews-api_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

reflow comments in public/platform/ BUG=563793 Committed: https://crrev.com/55e6683f5fad4e9ee67af77ffc2300cf4198c195 Cr-Commit-Position: refs/heads/master@{#422664}

Patch Set 1 #

Total comments: 2

Patch Set 2 : nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+458 lines, -344 lines) Patch
M third_party/WebKit/public/platform/Platform.h View 11 chunks +28 lines, -16 lines 0 comments Download
M third_party/WebKit/public/platform/WebAddressSpace.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/public/platform/WebApplicationCacheHost.h View 1 chunk +4 lines, -3 lines 0 comments Download
M third_party/WebKit/public/platform/WebApplicationCacheHostClient.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/public/platform/WebAudioBus.h View 2 chunks +14 lines, -12 lines 0 comments Download
M third_party/WebKit/public/platform/WebAudioDestinationConsumer.h View 2 chunks +12 lines, -11 lines 0 comments Download
M third_party/WebKit/public/platform/WebAudioSourceProvider.h View 2 chunks +11 lines, -10 lines 0 comments Download
M third_party/WebKit/public/platform/WebAudioSourceProviderClient.h View 1 chunk +9 lines, -9 lines 0 comments Download
M third_party/WebKit/public/platform/WebBlobRegistry.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/public/platform/WebCachePolicy.h View 1 chunk +4 lines, -2 lines 0 comments Download
M third_party/WebKit/public/platform/WebCompositorSupport.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/public/platform/WebContentLayerClient.h View 2 chunks +9 lines, -7 lines 0 comments Download
M third_party/WebKit/public/platform/WebCredentialManagerError.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/public/platform/WebCryptoAlgorithm.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/public/platform/WebCryptoAlgorithmParams.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/public/platform/WebDistillability.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/public/platform/WebDragData.h View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/public/platform/WebEditingCommandType.h View 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/WebKit/public/platform/WebEncryptedMediaTypes.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/public/platform/WebEventListenerProperties.h View 1 chunk +9 lines, -6 lines 0 comments Download
M third_party/WebKit/public/platform/WebExternalTextureLayer.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/public/platform/WebFileSystem.h View 5 chunks +41 lines, -22 lines 0 comments Download
M third_party/WebKit/public/platform/WebFileWriter.h View 1 chunk +5 lines, -2 lines 0 comments Download
M third_party/WebKit/public/platform/WebFileWriterClient.h View 1 chunk +3 lines, -1 line 0 comments Download
M third_party/WebKit/public/platform/WebFrameScheduler.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/public/platform/WebGestureCurve.h View 1 chunk +9 lines, -9 lines 0 comments Download
M third_party/WebKit/public/platform/WebGestureCurveTarget.h View 1 chunk +9 lines, -9 lines 0 comments Download
M third_party/WebKit/public/platform/WebImage.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/public/platform/WebInputEvent.h View 5 chunks +15 lines, -13 lines 0 comments Download
M third_party/WebKit/public/platform/WebInputEventResult.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/public/platform/WebLayer.h View 2 chunks +6 lines, -3 lines 0 comments Download
M third_party/WebKit/public/platform/WebLayerScrollClient.h View 1 chunk +9 lines, -9 lines 0 comments Download
M third_party/WebKit/public/platform/WebLayerTreeView.h View 3 chunks +19 lines, -13 lines 0 comments Download
M third_party/WebKit/public/platform/WebLoadingBehaviorFlag.h View 1 chunk +4 lines, -3 lines 0 comments Download
M third_party/WebKit/public/platform/WebMediaPlayer.h View 2 chunks +4 lines, -2 lines 0 comments Download
M third_party/WebKit/public/platform/WebMediaStream.h View 2 chunks +11 lines, -11 lines 0 comments Download
M third_party/WebKit/public/platform/WebMediaStreamCenter.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/public/platform/WebMediaStreamSource.h View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/public/platform/WebMediaStreamTrack.h View 2 chunks +11 lines, -11 lines 0 comments Download
M third_party/WebKit/public/platform/WebMessagePortChannel.h View 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/WebKit/public/platform/WebPrerender.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/public/platform/WebPrerenderingSupport.h View 1 chunk +4 lines, -3 lines 0 comments Download
M third_party/WebKit/public/platform/WebRTCCertificate.h View 1 chunk +9 lines, -8 lines 0 comments Download
M third_party/WebKit/public/platform/WebRTCCertificateGenerator.h View 2 chunks +8 lines, -5 lines 0 comments Download
M third_party/WebKit/public/platform/WebRTCDataChannelHandler.h View 1 chunk +9 lines, -9 lines 0 comments Download
M third_party/WebKit/public/platform/WebRTCDataChannelHandlerClient.h View 1 chunk +9 lines, -9 lines 0 comments Download
M third_party/WebKit/public/platform/WebRTCPeerConnectionHandler.h View 2 chunks +5 lines, -3 lines 0 comments Download
M third_party/WebKit/public/platform/WebRTCStats.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/public/platform/WebRTCStatsResponse.h View 1 chunk +9 lines, -9 lines 0 comments Download
M third_party/WebKit/public/platform/WebScheduler.h View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/public/platform/WebScrollbar.h View 1 chunk +9 lines, -9 lines 0 comments Download
M third_party/WebKit/public/platform/WebScrollbarThemePainter.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/public/platform/WebSecurityOrigin.h View 1 3 chunks +7 lines, -5 lines 0 comments Download
M third_party/WebKit/public/platform/WebSourceBuffer.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/public/platform/WebSourceBufferClient.h View 2 chunks +6 lines, -3 lines 0 comments Download
M third_party/WebKit/public/platform/WebSpeechSynthesisUtterance.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/public/platform/WebStorageArea.h View 2 chunks +14 lines, -12 lines 0 comments Download
M third_party/WebKit/public/platform/WebStorageNamespace.h View 1 chunk +8 lines, -6 lines 0 comments Download
M third_party/WebKit/public/platform/WebTaskRunner.h View 1 chunk +8 lines, -7 lines 0 comments Download
M third_party/WebKit/public/platform/WebThread.h View 1 chunk +8 lines, -4 lines 0 comments Download
M third_party/WebKit/public/platform/WebThreadSafeData.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/public/platform/WebURLLoaderClient.h View 2 chunks +4 lines, -2 lines 0 comments Download
M third_party/WebKit/public/platform/WebURLLoaderMockFactory.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/public/platform/WebURLRequest.h View 5 chunks +14 lines, -8 lines 0 comments Download
M third_party/WebKit/public/platform/WebURLResponse.h View 2 chunks +4 lines, -3 lines 0 comments Download
M third_party/WebKit/public/platform/WebViewScheduler.h View 2 chunks +18 lines, -15 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
Nico
4 years, 2 months ago (2016-10-03 17:21:18 UTC) #4
dcheng
LGTM https://codereview.chromium.org/2387113002/diff/1/third_party/WebKit/public/platform/WebSecurityOrigin.h File third_party/WebKit/public/platform/WebSecurityOrigin.h (right): https://codereview.chromium.org/2387113002/diff/1/third_party/WebKit/public/platform/WebSecurityOrigin.h#newcode120 third_party/WebKit/public/platform/WebSecurityOrigin.h:120: // We'll need to fix that for OOPI-enabled ...
4 years, 2 months ago (2016-10-03 18:11:48 UTC) #5
Nico
https://codereview.chromium.org/2387113002/diff/1/third_party/WebKit/public/platform/WebSecurityOrigin.h File third_party/WebKit/public/platform/WebSecurityOrigin.h (right): https://codereview.chromium.org/2387113002/diff/1/third_party/WebKit/public/platform/WebSecurityOrigin.h#newcode120 third_party/WebKit/public/platform/WebSecurityOrigin.h:120: // We'll need to fix that for OOPI-enabled embedders, ...
4 years, 2 months ago (2016-10-03 21:53:19 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2387113002/20001
4 years, 2 months ago (2016-10-03 21:54:04 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-04 01:57:31 UTC) #12
commit-bot: I haz the power
4 years, 2 months ago (2016-10-04 02:00:13 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/55e6683f5fad4e9ee67af77ffc2300cf4198c195
Cr-Commit-Position: refs/heads/master@{#422664}

Powered by Google App Engine
This is Rietveld 408576698