Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 2387093002: Reflow comments in canvas-related folders (Closed)

Created:
4 years, 2 months ago by xlai (Olivia)
Modified:
4 years, 2 months ago
Reviewers:
Justin Novosad
CC:
chromium-reviews, dshwang, ajuma+watch-canvas_chromium.org, blink-reviews-html_chromium.org, haraken, dglazkov+blink, Rik, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reflow comments in canvas-related folders This CL reflows comments based on new Blink format in the following folders: third_party/WebKit/Source/core/html/canvas/ third_party/WebKit/Source/core/offscreencanvas/ third_party/WebKit/Source/modules/canvas/ third_party/WebKit/Source/modules/canvas2d/ third_party/WebKit/Source/modules/offscreencanvas2d/ This CL has no behavior change. BUG=563793 Committed: https://crrev.com/5d6fc8b5a83846ca93f906584e0350855b194bdb Cr-Commit-Position: refs/heads/master@{#422543}

Patch Set 1 #

Total comments: 8

Patch Set 2 : fix #

Patch Set 3 : fix #

Patch Set 4 : More fix #

Patch Set 5 : More fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+193 lines, -125 lines) Patch
M third_party/WebKit/Source/core/html/canvas/CanvasAsyncBlobCreator.h View 2 chunks +6 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/html/canvas/CanvasAsyncBlobCreator.cpp View 2 chunks +6 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/html/canvas/CanvasAsyncBlobCreatorTest.cpp View 1 2 6 chunks +14 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/html/canvas/CanvasFontCache.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/canvas/CanvasImageSource.h View 2 chunks +6 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/html/canvas/CanvasRenderingContext.h View 1 1 chunk +7 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/html/canvas/CanvasRenderingContext.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/offscreencanvas/OffscreenCanvas.h View 2 chunks +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/canvas/HTMLCanvasElementModule.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/canvas/HTMLCanvasElementModuleTest.cpp View 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/canvas2d/BaseRenderingContext2D.cpp View 1 2 3 6 chunks +18 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/modules/canvas2d/CanvasPathMethods.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/canvas2d/CanvasPathMethods.cpp View 1 2 3 6 chunks +35 lines, -21 lines 0 comments Download
M third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2D.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2D.cpp View 1 2 3 20 chunks +53 lines, -38 lines 0 comments Download
M third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DAPITest.cpp View 1 2 chunks +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DState.h View 1 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DState.cpp View 1 2 chunks +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DTest.cpp View 1 2 3 4 6 chunks +12 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/modules/canvas2d/ClipList.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/offscreencanvas2d/OffscreenCanvasRenderingContext2D.cpp View 2 chunks +7 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
xlai (Olivia)
Recently they were doing this clang format in Blink (https://groups.google.com/a/chromium.org/d/msg/blink-dev/xGUEAYEB9dc/j6-s54ZoBQAJ), so I volunteer to do ...
4 years, 2 months ago (2016-10-03 17:14:46 UTC) #2
Justin Novosad
https://codereview.chromium.org/2387093002/diff/1/third_party/WebKit/Source/core/html/canvas/CanvasAsyncBlobCreatorTest.cpp File third_party/WebKit/Source/core/html/canvas/CanvasAsyncBlobCreatorTest.cpp (right): https://codereview.chromium.org/2387093002/diff/1/third_party/WebKit/Source/core/html/canvas/CanvasAsyncBlobCreatorTest.cpp#newcode229 third_party/WebKit/Source/core/html/canvas/CanvasAsyncBlobCreatorTest.cpp:229: // this This one is weird https://codereview.chromium.org/2387093002/diff/1/third_party/WebKit/Source/core/html/canvas/CanvasRenderingContext.h File third_party/WebKit/Source/core/html/canvas/CanvasRenderingContext.h ...
4 years, 2 months ago (2016-10-03 18:13:11 UTC) #3
xlai (Olivia)
My bad on not fixing all the weird auto-generated places. Now it's all fixed.
4 years, 2 months ago (2016-10-03 18:53:20 UTC) #4
Justin Novosad
lgtm
4 years, 2 months ago (2016-10-03 19:21:07 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2387093002/80001
4 years, 2 months ago (2016-10-03 19:54:43 UTC) #7
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 2 months ago (2016-10-03 21:39:51 UTC) #8
commit-bot: I haz the power
4 years, 2 months ago (2016-10-03 21:42:04 UTC) #10
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/5d6fc8b5a83846ca93f906584e0350855b194bdb
Cr-Commit-Position: refs/heads/master@{#422543}

Powered by Google App Engine
This is Rietveld 408576698