Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(590)

Issue 2387063002: [ozone/wayland] Use SurfacelessEGL when supported (Closed)

Created:
1 year, 2 months ago by tonikitoo
Modified:
1 year, 2 months ago
Reviewers:
rjkroege, kylechar
CC:
chromium-reviews, kalyank, ozone-reviews_chromium.org, fwang
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use SurfacelessEGL for ozone/wayland, when supported Since [1], chrome --mash --ozone-platform=wayland fails to launch in some systems, where the call to PbufferGLSurfaceEGL::Initialize (ui/gl/gl_surface_egl.cc) fails at EGLSurface new_surface = eglCreatePbufferSurface(display, GetConfig(), &pbuffer_attribs[0]); ... because GetConfig does not return a valid EGLConfig instance. As per @kylechar's advice, this CL opt-in for a SufacelessEGL creation, if supported, rather than PbufferGLSurfaceEGL, similarly to how it was prior to [1]. [1] https://codereview.chromium.org/2187443003 BUG=650284, 611142 Committed: https://crrev.com/903932cf3bcfa9a0eb58b3660c9bad83c4c7e3d3 Cr-Commit-Position: refs/heads/master@{#422475}

Patch Set 1 #

Messages

Total messages: 8 (3 generated)
tonikitoo
PTAL
1 year, 2 months ago (2016-10-03 15:02:31 UTC) #2
rjkroege
lgtm
1 year, 2 months ago (2016-10-03 17:35:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2387063002/1
1 year, 2 months ago (2016-10-03 18:42:13 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
1 year, 2 months ago (2016-10-03 18:53:01 UTC) #6
commit-bot: I haz the power
1 year, 2 months ago (2016-10-03 18:56:40 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/903932cf3bcfa9a0eb58b3660c9bad83c4c7e3d3
Cr-Commit-Position: refs/heads/master@{#422475}

Powered by Google App Engine
This is Rietveld 0eb02b776