Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Issue 2387053003: reflow comments in platform/{mediastream,scroll} (Closed)

Created:
4 years, 2 months ago by Nico
Modified:
4 years, 2 months ago
Reviewers:
pdr.
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, chromium-reviews, dcheng, Eric Willigers, kinuko+fileapi, mcasas+watch+mediastream_chromium.org, nhiroki, rjwright, shans, tommyw+watchlist_chromium.org, tzik
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

reflow comments in platform/{mediastream,scroll} BUG=563793 Committed: https://crrev.com/119f976164031b951476a52270160b926d804490 Cr-Commit-Position: refs/heads/master@{#422591}

Patch Set 1 #

Patch Set 2 : blah #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+105 lines, -68 lines) Patch
M third_party/WebKit/Source/platform/mediastream/MediaStreamComponent.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/mediastream/MediaStreamDescriptor.h View 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/mediastream/MediaStreamSource.h View 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/scroll/ScrollTypes.h View 2 chunks +5 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/scroll/ScrollableArea.h View 9 chunks +30 lines, -22 lines 0 comments Download
M third_party/WebKit/Source/platform/scroll/ScrollableArea.cpp View 4 chunks +13 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/platform/scroll/Scrollbar.h View 3 chunks +9 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/platform/scroll/Scrollbar.cpp View 5 chunks +14 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/platform/scroll/ScrollbarTheme.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/scroll/ScrollbarTheme.cpp View 3 chunks +6 lines, -5 lines 2 comments Download
M third_party/WebKit/Source/platform/scroll/ScrollbarThemeAura.cpp View 2 chunks +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/scroll/ScrollbarThemeMac.mm View 5 chunks +12 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/platform/scroll/ScrollbarThemeMock.h View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 11 (5 generated)
Nico
4 years, 2 months ago (2016-10-03 20:55:10 UTC) #4
pdr.
LGTM https://codereview.chromium.org/2387053003/diff/20001/third_party/WebKit/Source/platform/scroll/ScrollbarTheme.cpp File third_party/WebKit/Source/platform/scroll/ScrollbarTheme.cpp (left): https://codereview.chromium.org/2387053003/diff/20001/third_party/WebKit/Source/platform/scroll/ScrollbarTheme.cpp#oldcode265 third_party/WebKit/Source/platform/scroll/ScrollbarTheme.cpp:265: 0; // Once the thumb is below the ...
4 years, 2 months ago (2016-10-03 21:30:50 UTC) #5
Nico
thanks! https://codereview.chromium.org/2387053003/diff/20001/third_party/WebKit/Source/platform/scroll/ScrollbarTheme.cpp File third_party/WebKit/Source/platform/scroll/ScrollbarTheme.cpp (left): https://codereview.chromium.org/2387053003/diff/20001/third_party/WebKit/Source/platform/scroll/ScrollbarTheme.cpp#oldcode265 third_party/WebKit/Source/platform/scroll/ScrollbarTheme.cpp:265: 0; // Once the thumb is below the ...
4 years, 2 months ago (2016-10-03 21:34:43 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2387053003/20001
4 years, 2 months ago (2016-10-03 21:35:40 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-03 23:20:46 UTC) #9
commit-bot: I haz the power
4 years, 2 months ago (2016-10-03 23:24:36 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/119f976164031b951476a52270160b926d804490
Cr-Commit-Position: refs/heads/master@{#422591}

Powered by Google App Engine
This is Rietveld 408576698