reflow comments in platform/{mediastream,scroll}

third_party/WebKit/Source/platform/scroll/ScrollbarTheme.cpp

 /*
  * Copyright (C) 2011 Apple Inc. All Rights Reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 219 matching lines @@
   mousePosition.move(scrollbar.x(), scrollbar.y());
   return Platform::current()->scrollbarBehavior()->shouldSnapBackToDragOrigin(
       mousePosition, trackRect(scrollbar),
       scrollbar.orientation() == HorizontalScrollbar);
 }
 
 int ScrollbarTheme::thumbPosition(const ScrollbarThemeClient& scrollbar,
                                   float scrollPosition) {
   if (scrollbar.enabled()) {
     float size = scrollbar.totalSize() - scrollbar.visibleSize();
-    // Avoid doing a floating point divide by zero and return 1 when usedTotalSize == visibleSize.
+    // Avoid doing a floating point divide by zero and return 1 when
+    // usedTotalSize == visibleSize.
     if (!size)
       return 0;
     float pos = std::max(0.0f, scrollPosition) *
                 (trackLength(scrollbar) - thumbLength(scrollbar)) / size;
     return (pos < 1 && pos > 0) ? 1 : pos;
   }
   return 0;
 }
 
 int ScrollbarTheme::thumbLength(const ScrollbarThemeClient& scrollbar) {
   if (!scrollbar.enabled())
     return 0;
 
   float overhang = fabsf(scrollbar.elasticOverscroll());
   float proportion = 0.0f;
   float totalSize = scrollbar.totalSize();
   if (totalSize > 0.0f) {
     proportion = (scrollbar.visibleSize() - overhang) / totalSize;
   }
   int trackLen = trackLength(scrollbar);
   int length = round(proportion * trackLen);
   length = std::max(length, minimumThumbLength(scrollbar));
   if (length > trackLen)
-    length =
-        0;  // Once the thumb is below the track length, it just goes away (to make more room for the track).

[pdr., 2016/10/03 21:30:50]

This looks like it was an edge-case mistake in the big reformat. Do you think it
would be worth grepping for more instances of this? I am not sure how.

[Nico, 2016/10/03 21:34:42]

I think "ReflowComments: false" triggers this. When that's set, clang-format
can't break the comment and the line end, but column limit is 80, so to minimize
the damage, clang-format makes the line with the comment on it as short as
possible. The comment reflow cleanup (that this CL is part of) will fix this
issue everywhere it happened.

+    length = 0;  // Once the thumb is below the track length, it just goes away
+                 // (to make more room for the track).
   return length;
 }
 
 int ScrollbarTheme::trackPosition(const ScrollbarThemeClient& scrollbar) {
   IntRect constrainedTrackRect =
       constrainTrackRectToTrackPieces(scrollbar, trackRect(scrollbar));
   return (scrollbar.orientation() == HorizontalScrollbar)
              ? constrainedTrackRect.x() - scrollbar.x()
              : constrainedTrackRect.y() - scrollbar.y();
 }
@@ skipping 27 matching lines @@
 
 int ScrollbarTheme::minimumThumbLength(const ScrollbarThemeClient& scrollbar) {
   return scrollbarThickness(scrollbar.controlSize());
 }
 
 void ScrollbarTheme::splitTrack(const ScrollbarThemeClient& scrollbar,
                                 const IntRect& unconstrainedTrackRect,
                                 IntRect& beforeThumbRect,
                                 IntRect& thumbRect,
                                 IntRect& afterThumbRect) {
-  // This function won't even get called unless we're big enough to have some combination of these three rects where at least
-  // one of them is non-empty.
+  // This function won't even get called unless we're big enough to have some
+  // combination of these three rects where at least one of them is non-empty.
   IntRect trackRect =
       constrainTrackRectToTrackPieces(scrollbar, unconstrainedTrackRect);
   int thumbPos = thumbPosition(scrollbar);
   if (scrollbar.orientation() == HorizontalScrollbar) {
     thumbRect = IntRect(trackRect.x() + thumbPos, trackRect.y(),
                         thumbLength(scrollbar), scrollbar.height());
     beforeThumbRect =
         IntRect(trackRect.x(), trackRect.y(), thumbPos + thumbRect.width() / 2,
                 trackRect.height());
     afterThumbRect =
@@ skipping 55 matching lines @@
       return DisplayItem::kScrollbarBackTrack;
     case ForwardTrackPart:
       return DisplayItem::kScrollbarForwardTrack;
     default:
       ASSERT_NOT_REACHED();
       return DisplayItem::kScrollbarBackTrack;
   }
 }
 
 }  // namespace blink