[MD Extensions] Merge CSS into html files

[MD Extensions] Merge CSS into html files

Some MD extensions files had css in .css files, others had it in the
.html files. Settle on putting it in the .html files and make everything
conform.

No functional changes.

BUG=529395
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/a93b88ed2ccfc304dc156467fd6d3d92eee80442
Cr-Commit-Position: refs/heads/master@{#422489}

[Devlin, 2016-10-01 03:30:25]

Description was changed from

==========
[MD Extensions] Merge CSS into html files

Some MD extensions files had css in .css files, others had it in the
.html files. Settle on putting it in the .html files and make everything
conform.

No functional changes.

BUG=529395
==========

to

==========
[MD Extensions] Merge CSS into html files

Some MD extensions files had css in .css files, others had it in the
.html files. Settle on putting it in the .html files and make everything
conform.

No functional changes.

BUG=529395
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[Devlin, 2016-10-01 03:31:43]

The CQ bit was checked by rdevlin.cronin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-01 03:31:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Devlin, 2016-10-01 03:32:05]

rdevlin.cronin@chromium.org changed reviewers:
+ michaelpg@chromium.org

[Devlin, 2016-10-01 03:32:06]

Michael, mind taking a quick look?  No functional changes.

+Dan as FYI since he mentioned it.

[commit-bot: I haz the power, 2016-10-01 04:33:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-01 04:33:34]

Dry run: This issue passed the CQ dry run.

[michaelpg, 2016-10-03 05:43:21]

lgtm

https://codereview.chromium.org/2386813002/diff/1/chrome/browser/resources/md...
File chrome/browser/resources/md_extensions/item.html (right):

https://codereview.chromium.org/2386813002/diff/1/chrome/browser/resources/md...
chrome/browser/resources/md_extensions/item.html:22: #icon-wrapper {
channeling dan: why do you hate newlines?

[Dan Beam, 2016-10-03 06:00:49]

https://codereview.chromium.org/2386813002/diff/1/chrome/browser/resources/md...
File chrome/browser/resources/md_extensions/item.html (right):

https://codereview.chromium.org/2386813002/diff/1/chrome/browser/resources/md...
chrome/browser/resources/md_extensions/item.html:22: #icon-wrapper {
On 2016/10/03 05:43:21, michaelpg wrote:
> channeling dan: why do you hate newlines?

lol, seconded

[Devlin, 2016-10-03 16:13:25]

https://codereview.chromium.org/2386813002/diff/1/chrome/browser/resources/md...
File chrome/browser/resources/md_extensions/item.html (right):

https://codereview.chromium.org/2386813002/diff/1/chrome/browser/resources/md...
chrome/browser/resources/md_extensions/item.html:22: #icon-wrapper {
On 2016/10/03 06:00:49, Dan Beam wrote:
> On 2016/10/03 05:43:21, michaelpg wrote:
> > channeling dan: why do you hate newlines?
> 
> lol, seconded

In the particular case of CSS, the fact that we require the closing } to be on
its own line essentially serves the same purpose, doesn't it?  It's clear where
one rule ends and the other begins.  (This is also how the rest of md extensions
is formatted, so unless there's a real style rule, I'd have a preference to
remain consistent without needing to make another CL adjusting all of them.)

[michaelpg, 2016-10-03 16:34:41]

https://codereview.chromium.org/2386813002/diff/1/chrome/browser/resources/md...
File chrome/browser/resources/md_extensions/item.html (right):

https://codereview.chromium.org/2386813002/diff/1/chrome/browser/resources/md...
chrome/browser/resources/md_extensions/item.html:22: #icon-wrapper {
On 2016/10/03 16:13:25, Devlin (catching up) wrote:
> On 2016/10/03 06:00:49, Dan Beam wrote:
> > On 2016/10/03 05:43:21, michaelpg wrote:
> > > channeling dan: why do you hate newlines?
> > 
> > lol, seconded
> 
> In the particular case of CSS, the fact that we require the closing } to be on
> its own line essentially serves the same purpose, doesn't it?  It's clear
where
> one rule ends and the other begins.  (This is also how the rest of md
extensions
> is formatted, so unless there's a real style rule, I'd have a preference to
> remain consistent without needing to make another CL adjusting all of them.)

https://google.github.io/styleguide/htmlcssguide.xml?showone=Rule_Separation#...

I don't feel too strongly but since you're changing the white space in this
CL...

[Devlin, 2016-10-03 16:51:55]

https://codereview.chromium.org/2386813002/diff/1/chrome/browser/resources/md...
File chrome/browser/resources/md_extensions/item.html (right):

https://codereview.chromium.org/2386813002/diff/1/chrome/browser/resources/md...
chrome/browser/resources/md_extensions/item.html:22: #icon-wrapper {
On 2016/10/03 16:34:40, michaelpg wrote:
> On 2016/10/03 16:13:25, Devlin (catching up) wrote:
> > On 2016/10/03 06:00:49, Dan Beam wrote:
> > > On 2016/10/03 05:43:21, michaelpg wrote:
> > > > channeling dan: why do you hate newlines?
> > > 
> > > lol, seconded
> > 
> > In the particular case of CSS, the fact that we require the closing } to be
on
> > its own line essentially serves the same purpose, doesn't it?  It's clear
> where
> > one rule ends and the other begins.  (This is also how the rest of md
> extensions
> > is formatted, so unless there's a real style rule, I'd have a preference to
> > remain consistent without needing to make another CL adjusting all of them.)
> 
>
https://google.github.io/styleguide/htmlcssguide.xml?showone=Rule_Separation#...
> 
> I don't feel too strongly but since you're changing the white space in this
> CL...

Ah, there *is* a style rule.  Done.  I'll convert the other files in a followup.

[Devlin, 2016-10-03 16:51:59]

The CQ bit was checked by rdevlin.cronin@chromium.org

[Devlin, 2016-10-03 16:51:59]

The patchset sent to the CQ was uploaded after l-g-t-m from
michaelpg@chromium.org
Link to the patchset: https://codereview.chromium.org/2386813002/#ps20001
(title: "Newlines")

[commit-bot: I haz the power, 2016-10-03 16:52:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Dan Beam, 2016-10-03 18:21:39]

dbeam@chromium.org changed reviewers:
+ dbeam@chromium.org

[Dan Beam, 2016-10-03 18:21:40]

https://codereview.chromium.org/2386813002/diff/1/chrome/browser/resources/md...
File chrome/browser/resources/md_extensions/item.html (right):

https://codereview.chromium.org/2386813002/diff/1/chrome/browser/resources/md...
chrome/browser/resources/md_extensions/item.html:22: #icon-wrapper {
On 2016/10/03 16:51:55, Devlin (catching up) wrote:
> On 2016/10/03 16:34:40, michaelpg wrote:
> > On 2016/10/03 16:13:25, Devlin (catching up) wrote:
> > > On 2016/10/03 06:00:49, Dan Beam wrote:
> > > > On 2016/10/03 05:43:21, michaelpg wrote:
> > > > > channeling dan: why do you hate newlines?
> > > > 
> > > > lol, seconded
> > > 
> > > In the particular case of CSS, the fact that we require the closing } to
be
> on
> > > its own line essentially serves the same purpose, doesn't it?  It's clear
> > where
> > > one rule ends and the other begins.  (This is also how the rest of md
> > extensions
> > > is formatted, so unless there's a real style rule, I'd have a preference
to
> > > remain consistent without needing to make another CL adjusting all of
them.)
> > 
> >
>
https://google.github.io/styleguide/htmlcssguide.xml?showone=Rule_Separation#...
> > 
> > I don't feel too strongly but since you're changing the white space in this
> > CL...
> 
> Ah, there *is* a style rule.  Done.  I'll convert the other files in a
followup.

fwiw: local consistency vs global consistency is a tough call, typically

the general question is something like: is there a good reason for a local
deviation?  a good enough reason that you'd want the whole codebase to do it if
e.g. you started over from scratch.

[Devlin, 2016-10-03 18:39:47]

On 2016/10/03 18:21:40, Dan Beam wrote:
> fwiw: local consistency vs global consistency is a tough call, typically
> 
> the general question is something like: is there a good reason for a local
> deviation?  a good enough reason that you'd want the whole codebase to do it
if
> e.g. you started over from scratch.

Yeah.  Typically I opt for *at least* local consistency in cases where it's left
up to author discretion (e.g., {} around single-line ifs).  In this particular
case, I could see preferences in both directions - newlines generally help code
legibility, but IMHO, the closing } basically serves the same purpose, and we
generally don't add liberal/unnecessary whitespace (e.g., we have stylistic
rules to *not* put more than one newline).  But it would always come down to
opinion in the end.

But, as Michael keenly pointed out, that's not the case here, because there's a
concrete rule. :)

[commit-bot: I haz the power, 2016-10-03 18:44:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-03 18:44:09]

Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[Devlin, 2016-10-03 18:47:09]

The CQ bit was checked by rdevlin.cronin@chromium.org

[commit-bot: I haz the power, 2016-10-03 18:47:49]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-03 19:25:14]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-10-03 19:29:49]

Description was changed from

==========
[MD Extensions] Merge CSS into html files

Some MD extensions files had css in .css files, others had it in the
.html files. Settle on putting it in the .html files and make everything
conform.

No functional changes.

BUG=529395
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
[MD Extensions] Merge CSS into html files

Some MD extensions files had css in .css files, others had it in the
.html files. Settle on putting it in the .html files and make everything
conform.

No functional changes.

BUG=529395
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/a93b88ed2ccfc304dc156467fd6d3d92eee80442
Cr-Commit-Position: refs/heads/master@{#422489}
==========

[commit-bot: I haz the power, 2016-10-03 19:29:50]

Patchset 2 (id:??) landed as
https://crrev.com/a93b88ed2ccfc304dc156467fd6d3d92eee80442
Cr-Commit-Position: refs/heads/master@{#422489}