Chromium Code Reviews| OLD | NEW |
|---|---|
| 1 <link rel="import" href="chrome://resources/html/assert.html"> | 1 <link rel="import" href="chrome://resources/html/assert.html"> |
| 2 <link rel="import" href="chrome://resources/html/cr.html"> | 2 <link rel="import" href="chrome://resources/html/cr.html"> |
| 3 <link rel="import" href="chrome://resources/html/i18n_behavior.html"> | 3 <link rel="import" href="chrome://resources/html/i18n_behavior.html"> |
| 4 <link rel="import" href="chrome://resources/html/load_time_data.html"> | 4 <link rel="import" href="chrome://resources/html/load_time_data.html"> |
| 5 <link rel="import" href="chrome://resources/html/polymer.html"> | 5 <link rel="import" href="chrome://resources/html/polymer.html"> |
| 6 <link rel="import" href="chrome://extensions/icons.html"> | 6 <link rel="import" href="chrome://extensions/icons.html"> |
| 7 <link rel="import" href="chrome://extensions/item_source.html"> | 7 <link rel="import" href="chrome://extensions/item_source.html"> |
| 8 <link rel="import" href="chrome://extensions/strings.html"> | 8 <link rel="import" href="chrome://extensions/strings.html"> |
| 9 <link rel="import" href="chrome://resources/polymer/v1_0/iron-icons/iron-icons.h tml"> | 9 <link rel="import" href="chrome://resources/polymer/v1_0/iron-icons/iron-icons.h tml"> |
| 10 <link rel="import" href="chrome://resources/polymer/v1_0/iron-icons/communicatio n-icons.html"> | 10 <link rel="import" href="chrome://resources/polymer/v1_0/iron-icons/communicatio n-icons.html"> |
| 11 <link rel="import" href="chrome://resources/polymer/v1_0/iron-flex-layout/iron-f lex-layout-classes.html"> | 11 <link rel="import" href="chrome://resources/polymer/v1_0/iron-flex-layout/iron-f lex-layout-classes.html"> |
| 12 <link rel="import" href="chrome://resources/polymer/v1_0/paper-styles/shadow.htm l"> | 12 <link rel="import" href="chrome://resources/polymer/v1_0/paper-styles/shadow.htm l"> |
| 13 <link rel="import" href="chrome://resources/polymer/v1_0/paper-toggle-button/pap er-toggle-button.html"> | 13 <link rel="import" href="chrome://resources/polymer/v1_0/paper-toggle-button/pap er-toggle-button.html"> |
| 14 | 14 |
| 15 <dom-module id="extensions-item"> | 15 <dom-module id="extensions-item"> |
| 16 <style include="iron-flex"></style> | 16 <style include="iron-flex"></style> |
| 17 <template> | 17 <template> |
| 18 <style> | |
| 19 [hidden] { | |
| 20 display: none !important; | |
| 21 } | |
| 22 #icon-wrapper { | |
|
michaelpg
2016/10/03 05:43:21
channeling dan: why do you hate newlines?
Dan Beam
2016/10/03 06:00:49
lol, seconded
Devlin
2016/10/03 16:13:25
In the particular case of CSS, the fact that we re
michaelpg
2016/10/03 16:34:40
https://google.github.io/styleguide/htmlcssguide.x
Devlin
2016/10/03 16:51:55
Ah, there *is* a style rule. Done. I'll convert
Dan Beam
2016/10/03 18:21:40
fwiw: local consistency vs global consistency is a
| |
| 23 align-self: flex-start; | |
| 24 display: flex; | |
| 25 padding: 6px; | |
| 26 } | |
| 27 #icon { | |
| 28 height: 36px; | |
| 29 width: 36px; | |
| 30 } | |
| 31 #card, | |
| 32 #card-wrapper { | |
| 33 min-height: 154px; | |
| 34 width: 400px; | |
| 35 } | |
| 36 #card-wrapper { | |
| 37 @apply(--shadow-elevation-2dp); | |
| 38 background: white; | |
| 39 } | |
| 40 #card { | |
| 41 display: flex; | |
| 42 flex-direction: column; | |
| 43 font-size: 13px; | |
| 44 } | |
| 45 #card.disabled { | |
| 46 opacity: 0.6; | |
| 47 } | |
| 48 #main { | |
| 49 display: flex; | |
| 50 flex-grow: 1; | |
| 51 padding: 16px; | |
| 52 } | |
| 53 #content { | |
| 54 -webkit-margin-start: 24px; | |
| 55 width: 100%; | |
| 56 } | |
| 57 #name-and-version { | |
| 58 margin-bottom: 4px; | |
| 59 } | |
| 60 #name { | |
| 61 -webkit-margin-end: 8px; | |
| 62 color: var(--paper-grey-800); | |
| 63 } | |
| 64 #description { | |
| 65 margin-bottom: 8px; | |
| 66 } | |
| 67 #version, | |
| 68 #extension-id, | |
| 69 #inspect-views, | |
| 70 #button-strip { | |
| 71 color: var(--paper-grey-600); | |
| 72 } | |
| 73 #description, | |
| 74 #extension-id, | |
| 75 #inspect-views { | |
| 76 line-height: 20px; | |
| 77 } | |
| 78 #inspect-views paper-button { | |
| 79 color: var(--google-blue-700); | |
| 80 } | |
| 81 #button-strip { | |
| 82 border-top: 1px solid var(--paper-grey-400); | |
| 83 } | |
| 84 #source-indicator { | |
| 85 align-items: center; | |
| 86 align-self: flex-end; | |
| 87 border-radius: 0 2px; | |
| 88 color: var(--paper-grey-800); | |
| 89 display: flex; | |
| 90 min-height: 32px; | |
| 91 padding: 0 8px; | |
| 92 position: absolute; | |
| 93 white-space: nowrap; | |
| 94 } | |
| 95 #source-indicator iron-icon { | |
| 96 height: 16px; | |
| 97 width: 16px; | |
| 98 } | |
| 99 #source-indicator span { | |
| 100 -webkit-margin-end: 8px; | |
| 101 display: none; | |
| 102 } | |
| 103 #source-indicator:hover { | |
| 104 background-color: var(--paper-grey-700); | |
| 105 color: white; | |
| 106 } | |
| 107 #source-indicator:hover span { | |
| 108 display: block; | |
| 109 } | |
| 110 paper-button, | |
| 111 paper-toggle-button { | |
| 112 cursor: pointer; | |
| 113 } | |
| 114 #button-strip paper-button { | |
| 115 align-items: center; | |
| 116 display: flex; | |
| 117 margin: 4px; | |
| 118 min-height: 32px; | |
| 119 padding: 0 12px; | |
| 120 text-transform: uppercase; | |
| 121 } | |
| 122 #enable-toggle { | |
| 123 -webkit-margin-end: 16px; | |
| 124 } | |
| 125 .warning { | |
| 126 align-items: center; | |
| 127 display: flex; | |
| 128 font-size: 13px; | |
| 129 justify-content: space-between; | |
| 130 padding: 12px 16px; | |
| 131 } | |
| 132 .warning paper-button { | |
| 133 -webkit-margin-start: 12px; | |
| 134 align-items: center; | |
| 135 display: flex; | |
| 136 text-transform: uppercase; | |
| 137 } | |
| 138 .severe.warning { | |
| 139 background-color: var(--paper-red-50); | |
| 140 color: var(--paper-red-700); | |
| 141 } | |
| 142 .mild.warning { | |
| 143 background-color: var(--paper-yellow-50); | |
| 144 color: var(--paper-grey-600); | |
| 145 } | |
| 146 #blacklisted-warning:empty { | |
| 147 display: none; | |
| 148 } | |
| 149 </style> | |
| 18 <div id="card-wrapper" class$="[[computeClasses_(data.state)]]"> | 150 <div id="card-wrapper" class$="[[computeClasses_(data.state)]]"> |
| 19 <div id="card"> | 151 <div id="card"> |
| 20 <template is="dom-if" | 152 <template is="dom-if" |
| 21 if="[[computeSourceIndicatorIcon_(data.*)]]"> | 153 if="[[computeSourceIndicatorIcon_(data.*)]]"> |
| 22 <div id="source-indicator"> | 154 <div id="source-indicator"> |
| 23 <span>[[computeSourceIndicatorText_(data.*)]]</span> | 155 <span>[[computeSourceIndicatorText_(data.*)]]</span> |
| 24 <iron-icon icon="[[computeSourceIndicatorIcon_(data.*)]]"> | 156 <iron-icon icon="[[computeSourceIndicatorIcon_(data.*)]]"> |
| 25 </iron-icon> | 157 </iron-icon> |
| 26 </div> | 158 </div> |
| 27 </template> | 159 </template> |
| (...skipping 48 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 76 <paper-button id="repair-button" on-tap="onRepairTap_"> | 208 <paper-button id="repair-button" on-tap="onRepairTap_"> |
| 77 $i18n{itemRepair} | 209 $i18n{itemRepair} |
| 78 </paper-button> | 210 </paper-button> |
| 79 </div> | 211 </div> |
| 80 <div id="blacklisted-warning" class="warning severe"><!-- No whitespace | 212 <div id="blacklisted-warning" class="warning severe"><!-- No whitespace |
| 81 -->[[data.blacklistText]]<!-- ... so we can use :empty in css | 213 -->[[data.blacklistText]]<!-- ... so we can use :empty in css |
| 82 --></div> | 214 --></div> |
| 83 </template> | 215 </template> |
| 84 </div> | 216 </div> |
| 85 </template> | 217 </template> |
| 86 <link rel="import" type="css" href="chrome://extensions/item.css"> | |
| 87 <script src="chrome://extensions/item.js"></script> | 218 <script src="chrome://extensions/item.js"></script> |
| 88 </dom-module> | 219 </dom-module> |
| OLD | NEW |