services/ui: Match naming in cc (and jellyfish branch)

services/ui: Match naming in cc (and jellyfish branch)

DisplayCompositor => CompositorFrameSink
SurfacesState => DisplayCompositor

BUG=647852
Committed: https://crrev.com/afec9f4d069fc3bf6d56fdf85a7699d70bd0355b
Cr-Commit-Position: refs/heads/master@{#422510}

[Fady Samuel, 2016-09-30 22:44:50]

fsamuel@chromium.org changed reviewers:
+ sky@chromium.org

[sky, 2016-10-03 16:16:02]

LGTM with the following addressed.

https://codereview.chromium.org/2386763002/diff/20001/services/ui/surfaces/di...
File services/ui/surfaces/display_compositor.h (right):

https://codereview.chromium.org/2386763002/diff/20001/services/ui/surfaces/di...
services/ui/surfaces/display_compositor.h:21: // The DisplayCompositor object is
an object global to the Window Manager app
Manager->Server

https://codereview.chromium.org/2386763002/diff/20001/services/ui/surfaces/di...
services/ui/surfaces/display_compositor.h:23: // This object lives on the main
thread of the Window Manager.
Manager->Server

https://codereview.chromium.org/2386763002/diff/20001/services/ui/surfaces/di...
services/ui/surfaces/display_compositor.h:30: uint32_t next_client_id() { return
next_client_id_++; }
I would expect a function with this name to be a trivial getter, not have side
effects. Maybe GenerateNextClientId?

https://codereview.chromium.org/2386763002/diff/20001/services/ui/ws/platform...
File services/ui/ws/platform_display_init_params.h (right):

https://codereview.chromium.org/2386763002/diff/20001/services/ui/ws/platform...
services/ui/ws/platform_display_init_params.h:15: class GpuState;
sort

[Fady Samuel, 2016-10-03 18:27:07]

Addressed comments. Thanks Scott! CQ'ing.

https://codereview.chromium.org/2386763002/diff/20001/services/ui/surfaces/di...
File services/ui/surfaces/display_compositor.h (right):

https://codereview.chromium.org/2386763002/diff/20001/services/ui/surfaces/di...
services/ui/surfaces/display_compositor.h:21: // The DisplayCompositor object is
an object global to the Window Manager app
On 2016/10/03 16:16:02, sky wrote:
> Manager->Server

Done.

https://codereview.chromium.org/2386763002/diff/20001/services/ui/surfaces/di...
services/ui/surfaces/display_compositor.h:23: // This object lives on the main
thread of the Window Manager.
On 2016/10/03 16:16:02, sky wrote:
> Manager->Server

Done.

https://codereview.chromium.org/2386763002/diff/20001/services/ui/surfaces/di...
services/ui/surfaces/display_compositor.h:30: uint32_t next_client_id() { return
next_client_id_++; }
On 2016/10/03 16:16:02, sky wrote:
> I would expect a function with this name to be a trivial getter, not have side
> effects. Maybe GenerateNextClientId?

Done.

https://codereview.chromium.org/2386763002/diff/20001/services/ui/ws/platform...
File services/ui/ws/platform_display_init_params.h (right):

https://codereview.chromium.org/2386763002/diff/20001/services/ui/ws/platform...
services/ui/ws/platform_display_init_params.h:15: class GpuState;
On 2016/10/03 16:16:02, sky wrote:
> sort

Done.

[Fady Samuel, 2016-10-03 18:27:11]

The CQ bit was checked by fsamuel@chromium.org

[Fady Samuel, 2016-10-03 18:27:12]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org
Link to the patchset: https://codereview.chromium.org/2386763002/#ps40001
(title: "Addressed Scott's comments")

[commit-bot: I haz the power, 2016-10-03 18:27:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-03 18:39:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-03 18:39:23]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Fady Samuel, 2016-10-03 19:28:05]

The CQ bit was checked by fsamuel@chromium.org

[Fady Samuel, 2016-10-03 19:28:06]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org
Link to the patchset: https://codereview.chromium.org/2386763002/#ps60001
(title: "Fixed unittests")

[Fady Samuel, 2016-10-03 19:28:24]

The CQ bit was unchecked by fsamuel@chromium.org

[Fady Samuel, 2016-10-03 19:30:38]

The CQ bit was checked by fsamuel@chromium.org

[Fady Samuel, 2016-10-03 19:30:38]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org
Link to the patchset: https://codereview.chromium.org/2386763002/#ps80001
(title: "Removed bad change")

[commit-bot: I haz the power, 2016-10-03 19:31:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-03 20:23:24]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-10-03 20:25:59]

Description was changed from

==========
services/ui: Match naming in cc (and jellyfish branch)

DisplayCompositor => CompositorFrameSink
SurfacesState => DisplayCompositor

BUG=647852
==========

to

==========
services/ui: Match naming in cc (and jellyfish branch)

DisplayCompositor => CompositorFrameSink
SurfacesState => DisplayCompositor

BUG=647852

Committed: https://crrev.com/afec9f4d069fc3bf6d56fdf85a7699d70bd0355b
Cr-Commit-Position: refs/heads/master@{#422510}
==========

[commit-bot: I haz the power, 2016-10-03 20:26:00]

Patchset 5 (id:??) landed as
https://crrev.com/afec9f4d069fc3bf6d56fdf85a7699d70bd0355b
Cr-Commit-Position: refs/heads/master@{#422510}