Ignore return type annotations in @CalledByNative methods.

Ignore return type annotations in @CalledByNative methods.

Annotations do not affect generated JNI signatures so they should be
ignored. This CL updates the regex used to ignore return type
annotations (annotated method parameters are already ignored).

BUG=650823
Committed: https://crrev.com/799c1feb38d8fb1052bfdaaac6eaf1093f89bb2b
Cr-Commit-Position: refs/heads/master@{#422215}

[estevenson, 2016-09-30 19:50:35]

estevenson@chromium.org changed reviewers:
+ agrieve@chromium.org

[estevenson, 2016-09-30 19:50:35]

ptal Andrew!

[agrieve, 2016-09-30 20:07:17]

lgtm

https://codereview.chromium.org/2386713002/diff/1/base/android/jni_generator/...
File base/android/jni_generator/jni_generator.py (right):

https://codereview.chromium.org/2386713002/diff/1/base/android/jni_generator/...
base/android/jni_generator/jni_generator.py:521: '(:?\s*@\w+|)'  # Ignore
annotations in return types.
nit: would be a bit more normal to do:
(:?\s*@\w+)?

[estevenson, 2016-09-30 20:14:02]

https://codereview.chromium.org/2386713002/diff/1/base/android/jni_generator/...
File base/android/jni_generator/jni_generator.py (right):

https://codereview.chromium.org/2386713002/diff/1/base/android/jni_generator/...
base/android/jni_generator/jni_generator.py:521: '(:?\s*@\w+|)'  # Ignore
annotations in return types.
On 2016/09/30 20:07:16, agrieve wrote:
> nit: would be a bit more normal to do:
> (:?\s*@\w+)?

Done.

[estevenson, 2016-09-30 20:15:01]

The CQ bit was checked by estevenson@chromium.org

[estevenson, 2016-09-30 20:15:02]

The patchset sent to the CQ was uploaded after l-g-t-m from agrieve@chromium.org
Link to the patchset: https://codereview.chromium.org/2386713002/#ps20001
(title: "Make regex normal")

[commit-bot: I haz the power, 2016-09-30 20:15:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-30 20:53:14]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-30 20:56:35]

Description was changed from

==========
Ignore return type annotations in @CalledByNative methods.

Annotations do not affect generated JNI signatures so they should be
ignored. This CL updates the regex used to ignore return type
annotations (annotated method parameters are already ignored).

BUG=650823
==========

to

==========
Ignore return type annotations in @CalledByNative methods.

Annotations do not affect generated JNI signatures so they should be
ignored. This CL updates the regex used to ignore return type
annotations (annotated method parameters are already ignored).

BUG=650823

Committed: https://crrev.com/799c1feb38d8fb1052bfdaaac6eaf1093f89bb2b
Cr-Commit-Position: refs/heads/master@{#422215}
==========

[commit-bot: I haz the power, 2016-09-30 20:56:36]

Patchset 2 (id:??) landed as
https://crrev.com/799c1feb38d8fb1052bfdaaac6eaf1093f89bb2b
Cr-Commit-Position: refs/heads/master@{#422215}

[Ted C, 2016-09-30 20:59:33]

On 2016/09/30 20:56:36, commit-bot: I haz the power wrote:
> Patchset 2 (id:??) landed as
> https://crrev.com/799c1feb38d8fb1052bfdaaac6eaf1093f89bb2b
> Cr-Commit-Position: refs/heads/master@{#422215}

Woot!