Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(990)

Unified Diff: base/android/jni_generator/jni_generator_tests.py

Issue 2386713002: Ignore return type annotations in @CalledByNative methods. (Closed)
Patch Set: Make regex normal Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/android/jni_generator/jni_generator.py ('k') | base/android/jni_generator/testCalledByNatives.golden » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/android/jni_generator/jni_generator_tests.py
diff --git a/base/android/jni_generator/jni_generator_tests.py b/base/android/jni_generator/jni_generator_tests.py
index 9bd5ed5d8db6cc2eb521c38c6d63c7b74f227699..2596891a8e56ad483185528d80bd9d0084286738 100755
--- a/base/android/jni_generator/jni_generator_tests.py
+++ b/base/android/jni_generator/jni_generator_tests.py
@@ -402,6 +402,10 @@ class TestGenerator(unittest.TestCase):
return
}
}
+ @CalledByNative
+ public static @Status int updateStatus(@Status int status) {
+ return getAndUpdateStatus(status);
+ }
@CalledByNativeUnchecked
private void uncheckedCall(int iParam);
@@ -524,6 +528,17 @@ class TestGenerator(unittest.TestCase):
unchecked=False,
),
CalledByNative(
+ return_type='int',
+ system_class=False,
+ static=True,
+ name='updateStatus',
+ method_id_var_name='updateStatus',
+ java_class_name='',
+ params=[Param(datatype='int', name='status')],
+ env_call=('Integer', ''),
+ unchecked=False,
+ ),
+ CalledByNative(
return_type='void',
system_class=False,
static=False,
« no previous file with comments | « base/android/jni_generator/jni_generator.py ('k') | base/android/jni_generator/testCalledByNatives.golden » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698