Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Unified Diff: components/test_runner/web_test_interfaces.cc

Issue 2386683002: Do not store TestRunner in WebFrameTestClient. (Closed)
Patch Set: s/test_runner_/test_runner()/ for one case pulled after rebasing. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/test_runner/web_frame_test_client.cc ('k') | components/test_runner/web_view_test_client.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/test_runner/web_test_interfaces.cc
diff --git a/components/test_runner/web_test_interfaces.cc b/components/test_runner/web_test_interfaces.cc
index 184032205eb0c3199b034b226e15ec784cc3542c..6f87eb64971e00803d3db20eff37ef6d19791ef2 100644
--- a/components/test_runner/web_test_interfaces.cc
+++ b/components/test_runner/web_test_interfaces.cc
@@ -93,15 +93,16 @@ WebTestInterfaces::CreateAppBannerClient() {
std::unique_ptr<WebFrameTestClient> WebTestInterfaces::CreateWebFrameTestClient(
WebViewTestProxyBase* web_view_test_proxy_base,
WebFrameTestProxyBase* web_frame_test_proxy_base) {
- return base::MakeUnique<WebFrameTestClient>(
- interfaces_->GetTestRunner(), interfaces_->GetDelegate(),
- web_view_test_proxy_base, web_frame_test_proxy_base);
+ // TODO(lukasza): Do not pass the WebTestDelegate below - it's lifetime can
+ // differ from the lifetime of WebFrameTestClient - https://crbug.com/606594.
+ return base::MakeUnique<WebFrameTestClient>(interfaces_->GetDelegate(),
+ web_view_test_proxy_base,
+ web_frame_test_proxy_base);
}
std::unique_ptr<WebViewTestClient> WebTestInterfaces::CreateWebViewTestClient(
WebViewTestProxyBase* web_view_test_proxy_base) {
- return base::MakeUnique<WebViewTestClient>(interfaces_->GetTestRunner(),
- web_view_test_proxy_base);
+ return base::MakeUnique<WebViewTestClient>(web_view_test_proxy_base);
}
std::unique_ptr<WebWidgetTestClient>
« no previous file with comments | « components/test_runner/web_frame_test_client.cc ('k') | components/test_runner/web_view_test_client.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698