Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(1075)

Issue 2386433002: Move CPDF_Reference::SafeGetDirect() out of the header. (Closed)

Created:
4 years ago by Lei Zhang
Modified:
3 years, 12 months ago
Reviewers:
Tom Sepez, dsinclair, Wei Li
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Move CPDF_Reference::SafeGetDirect() out of the header. Committed: https://pdfium.googlesource.com/pdfium/+/3a88205e8ddce125d78fb6961f7eac2470bbcd55

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -8 lines) Patch
M core/fpdfapi/fpdf_parser/cpdf_reference.h View 1 2 chunks +3 lines, -8 lines 0 comments Download
M core/fpdfapi/fpdf_parser/cpdf_reference.cpp View 1 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
Lei Zhang
Will land after all the dust has settled.
4 years ago (2016-09-29 19:06:02 UTC) #2
Tom Sepez
lgtm
4 years ago (2016-09-29 19:10:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2386433002/20001
3 years, 12 months ago (2016-09-30 22:54:28 UTC) #6
commit-bot: I haz the power
3 years, 12 months ago (2016-09-30 23:06:42 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/3a88205e8ddce125d78fb6961f7eac2470bb...

Powered by Google App Engine
This is Rietveld 408576698