Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Side by Side Diff: core/fpdfapi/fpdf_parser/cpdf_reference.h

Issue 2386433002: Move CPDF_Reference::SafeGetDirect() out of the header. (Closed)
Patch Set: rebase Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | core/fpdfapi/fpdf_parser/cpdf_reference.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 PDFium Authors. All rights reserved. 1 // Copyright 2016 PDFium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com 5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
6 6
7 #ifndef CORE_FPDFAPI_FPDF_PARSER_CPDF_REFERENCE_H_ 7 #ifndef CORE_FPDFAPI_FPDF_PARSER_CPDF_REFERENCE_H_
8 #define CORE_FPDFAPI_FPDF_PARSER_CPDF_REFERENCE_H_ 8 #define CORE_FPDFAPI_FPDF_PARSER_CPDF_REFERENCE_H_
9 9
10 #include <set> 10 #include <set>
11 11
12 #include "core/fpdfapi/fpdf_parser/cpdf_object.h" 12 #include "core/fpdfapi/fpdf_parser/cpdf_object.h"
13 13
14 class CPDF_IndirectObjectHolder; 14 class CPDF_IndirectObjectHolder;
15 15
16 class CPDF_Reference : public CPDF_Object { 16 class CPDF_Reference : public CPDF_Object {
17 public: 17 public:
18 CPDF_Reference(CPDF_IndirectObjectHolder* pDoc, int objnum); 18 CPDF_Reference(CPDF_IndirectObjectHolder* pDoc, int objnum);
19 19
20 // CPDF_Object. 20 // CPDF_Object.
21 Type GetType() const override; 21 Type GetType() const override;
22 CPDF_Object* Clone() const override; 22 CPDF_Object* Clone() const override;
23 CPDF_Object* GetDirect() const override; 23 CPDF_Object* GetDirect() const override;
24 CFX_ByteString GetString() const override; 24 CFX_ByteString GetString() const override;
25 FX_FLOAT GetNumber() const override; 25 FX_FLOAT GetNumber() const override;
26 int GetInteger() const override; 26 int GetInteger() const override;
27 CPDF_Dictionary* GetDict() const override; 27 CPDF_Dictionary* GetDict() const override;
28
29 // TODO(weili): check whether GetUnicodeText() and GetArray() are needed.
30 bool IsReference() const override; 28 bool IsReference() const override;
31 CPDF_Reference* AsReference() override; 29 CPDF_Reference* AsReference() override;
32 const CPDF_Reference* AsReference() const override; 30 const CPDF_Reference* AsReference() const override;
33 31
34 CPDF_IndirectObjectHolder* GetObjList() const { return m_pObjList; } 32 CPDF_IndirectObjectHolder* GetObjList() const { return m_pObjList; }
35 uint32_t GetRefObjNum() const { return m_RefObjNum; } 33 uint32_t GetRefObjNum() const { return m_RefObjNum; }
36 34
37 void SetRef(CPDF_IndirectObjectHolder* pDoc, uint32_t objnum); 35 void SetRef(CPDF_IndirectObjectHolder* pDoc, uint32_t objnum);
38 36
39 protected: 37 protected:
40 ~CPDF_Reference() override; 38 ~CPDF_Reference() override;
39
41 CPDF_Object* CloneNonCyclic( 40 CPDF_Object* CloneNonCyclic(
42 bool bDirect, 41 bool bDirect,
43 std::set<const CPDF_Object*>* pVisited) const override; 42 std::set<const CPDF_Object*>* pVisited) const override;
44 CPDF_Object* SafeGetDirect() const { 43
45 CPDF_Object* obj = GetDirect(); 44 CPDF_Object* SafeGetDirect() const;
46 if (!obj || obj->IsReference())
47 return nullptr;
48 return obj;
49 }
50 45
51 CPDF_IndirectObjectHolder* m_pObjList; 46 CPDF_IndirectObjectHolder* m_pObjList;
52 uint32_t m_RefObjNum; 47 uint32_t m_RefObjNum;
53 }; 48 };
54 49
55 #endif // CORE_FPDFAPI_FPDF_PARSER_CPDF_REFERENCE_H_ 50 #endif // CORE_FPDFAPI_FPDF_PARSER_CPDF_REFERENCE_H_
OLDNEW
« no previous file with comments | « no previous file | core/fpdfapi/fpdf_parser/cpdf_reference.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698