chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchHeuristic.java - Issue 2386413002: [Contextual Search] Do not include tap suppression in aggregate heuristic logging

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchHeuristic.java

Issue 2386413002: [Contextual Search] Do not include tap suppression in aggregate heuristic logging (Closed)

Patch Set: [Contextual Search] Do not include tap suppression in aggregate heuristic logging Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/BarOverlapTapSuppression.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/CtrSuppression.java » ('j') | chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/NearTopTapSuppression.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchHeuristic.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchHeuristic.java b/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchHeuristic.java

index 8fdb708f05f27a07be9000fb4c857a3c4c5345c5..16bfd0f8d38ea0284e09b1cdcbd4285c025009b3 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchHeuristic.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchHeuristic.java

@@ -40,7 +40,7 @@ abstract class ContextualSearchHeuristic {

* suppression.

protected boolean shouldAggregateLogForTapSuppression() {

- return true;

+ return false;

}

/**

@@ -48,5 +48,7 @@ abstract class ContextualSearchHeuristic {

* suppression, if it were enabled through VariationsAssociatedData. If the feature is

* enabled through VariationsAssociatedData then this method should return false.

- protected abstract boolean isConditionSatisfiedForAggregateLogging();

+ protected boolean isConditionSatisfiedForAggregateLogging() {

+ return false;

+ }

}