Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3807)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/NearTopTapSuppression.java

Issue 2386413002: [Contextual Search] Do not include tap suppression in aggregate heuristic logging (Closed)
Patch Set: [Contextual Search] Do not include tap suppression in aggregate heuristic logging Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/NearTopTapSuppression.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/NearTopTapSuppression.java b/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/NearTopTapSuppression.java
index 8606ba4928d9cd06d45bf0cd0e2a5d9da902362c..39bf83f7362fd71d3b7be2698bf430aa7d93c779 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/NearTopTapSuppression.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/NearTopTapSuppression.java
@@ -46,10 +46,6 @@ public class NearTopTapSuppression extends ContextualSearchHeuristic {
}
}
- @Override
- protected boolean isConditionSatisfiedForAggregateLogging() {
- // TODO(twellington): Define a default value to use when determining if the condition is
- // satisfied for logging.
- return false;
- }
+ // TODO(twellington): Define a default value to use when determining if the condition is
Donn Denman 2016/10/04 20:55:29 Let's just do this so we can get rid of the TODO?
Theresa 2016/10/04 21:10:37 If mExperimentThreshold == 0 then mIsConditionSati
+ // satisfied for logging.
}

Powered by Google App Engine
This is Rietveld 408576698