Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(366)

Unified Diff: third_party/WebKit/Source/core/timing/PerformanceLongTaskTiming.cpp

Issue 2386403002: Pass DOMWinow to PerformanceLongTaskTiming for attribution (Closed)
Patch Set: sync to head following blink reformat Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/timing/PerformanceLongTaskTiming.cpp
diff --git a/third_party/WebKit/Source/core/timing/PerformanceLongTaskTiming.cpp b/third_party/WebKit/Source/core/timing/PerformanceLongTaskTiming.cpp
index 3d7dda02e67cf30c8a68801c89cdef669175b9d1..d8d427de1fab5427d71019cf3f8bbee8719b193d 100644
--- a/third_party/WebKit/Source/core/timing/PerformanceLongTaskTiming.cpp
+++ b/third_party/WebKit/Source/core/timing/PerformanceLongTaskTiming.cpp
@@ -4,16 +4,31 @@
#include "core/timing/PerformanceLongTaskTiming.h"
+#include "bindings/core/v8/V8ObjectBuilder.h"
+#include "core/frame/DOMWindow.h"
+
namespace blink {
PerformanceLongTaskTiming::PerformanceLongTaskTiming(double startTime,
double endTime,
- String frameContextUrl)
- : PerformanceEntry(frameContextUrl, "longtask", startTime, endTime) {}
+ String name,
+ DOMWindow* culpritWindow)
+ : PerformanceEntry(name, "longtask", startTime, endTime),
+ m_culpritWindow(*culpritWindow) {}
PerformanceLongTaskTiming::~PerformanceLongTaskTiming() {}
+DOMWindow* PerformanceLongTaskTiming::culpritWindow() const {
+ return m_culpritWindow.get();
+}
+
+void PerformanceLongTaskTiming::buildJSONValue(V8ObjectBuilder& builder) const {
+ PerformanceEntry::buildJSONValue(builder);
+ builder.add("culpritWindow", culpritWindow());
caseq 2016/10/05 00:22:18 This looks suspicious to me -- we can't really ser
panicker 2016/10/05 01:02:18 Done.
+}
+
DEFINE_TRACE(PerformanceLongTaskTiming) {
+ visitor->trace(m_culpritWindow);
PerformanceEntry::trace(visitor);
}

Powered by Google App Engine
This is Rietveld 408576698