Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Side by Side Diff: third_party/WebKit/Source/core/timing/PerformanceLongTaskTiming.cpp

Issue 2386403002: Pass DOMWinow to PerformanceLongTaskTiming for attribution (Closed)
Patch Set: sync to head following blink reformat Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "core/timing/PerformanceLongTaskTiming.h" 5 #include "core/timing/PerformanceLongTaskTiming.h"
6 6
7 #include "bindings/core/v8/V8ObjectBuilder.h"
8 #include "core/frame/DOMWindow.h"
9
7 namespace blink { 10 namespace blink {
8 11
9 PerformanceLongTaskTiming::PerformanceLongTaskTiming(double startTime, 12 PerformanceLongTaskTiming::PerformanceLongTaskTiming(double startTime,
10 double endTime, 13 double endTime,
11 String frameContextUrl) 14 String name,
12 : PerformanceEntry(frameContextUrl, "longtask", startTime, endTime) {} 15 DOMWindow* culpritWindow)
16 : PerformanceEntry(name, "longtask", startTime, endTime),
17 m_culpritWindow(*culpritWindow) {}
13 18
14 PerformanceLongTaskTiming::~PerformanceLongTaskTiming() {} 19 PerformanceLongTaskTiming::~PerformanceLongTaskTiming() {}
15 20
21 DOMWindow* PerformanceLongTaskTiming::culpritWindow() const {
22 return m_culpritWindow.get();
23 }
24
25 void PerformanceLongTaskTiming::buildJSONValue(V8ObjectBuilder& builder) const {
26 PerformanceEntry::buildJSONValue(builder);
27 builder.add("culpritWindow", culpritWindow());
caseq 2016/10/05 00:22:18 This looks suspicious to me -- we can't really ser
panicker 2016/10/05 01:02:18 Done.
28 }
29
16 DEFINE_TRACE(PerformanceLongTaskTiming) { 30 DEFINE_TRACE(PerformanceLongTaskTiming) {
31 visitor->trace(m_culpritWindow);
17 PerformanceEntry::trace(visitor); 32 PerformanceEntry::trace(visitor);
18 } 33 }
19 34
20 } // namespace blink 35 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698