third_party/WebKit/Source/platform/fonts/shaping/CaseMappingHarfBuzzBufferFiller.cpp - Issue 2386333002: reflow comments in platform/fonts

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/fonts/shaping/CaseMappingHarfBuzzBufferFiller.cpp

Issue 2386333002: reflow comments in platform/fonts (Closed)

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/platform/fonts/GlyphMetricsMap.h ('K') | « third_party/WebKit/Source/platform/fonts/shaping/CachingWordShaperTest.cpp ('k') | third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzShaper.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/fonts/shaping/CaseMappingHarfBuzzBufferFiller.cpp

diff --git a/third_party/WebKit/Source/platform/fonts/shaping/CaseMappingHarfBuzzBufferFiller.cpp b/third_party/WebKit/Source/platform/fonts/shaping/CaseMappingHarfBuzzBufferFiller.cpp

index d1adec443e552890fce22f8e5541adfcc62a4641..41e83913b2ce3a8280b9192a4172f3cf5f14c59d 100644

--- a/third_party/WebKit/Source/platform/fonts/shaping/CaseMappingHarfBuzzBufferFiller.cpp

+++ b/third_party/WebKit/Source/platform/fonts/shaping/CaseMappingHarfBuzzBufferFiller.cpp

@@ -51,7 +51,8 @@ CaseMappingHarfBuzzBufferFiller::CaseMappingHarfBuzzBufferFiller(

}

-// TODO(drott): crbug.com/623940 Fix lack of context sensitive case mapping here.

+// TODO(drott): crbug.com/623940 Fix lack of context sensitive case mapping

+// here.

void CaseMappingHarfBuzzBufferFiller::fillSlowCase(CaseMapIntend caseMapIntend,

AtomicString locale,

const UChar* buffer,

@@ -77,7 +78,8 @@ void CaseMappingHarfBuzzBufferFiller::fillSlowCase(CaseMapIntend caseMapIntend,

UChar32 codepoint = 0;

U16_NEXT(caseMappedChar.characters16(), j, caseMappedChar.length(),

codepoint);

- // Add all characters of the case mapping result at the same cluster position.

+ // Add all characters of the case mapping result at the same cluster

+ // position.

hb_buffer_add(m_harfBuzzBuffer, codepoint, charIndex);

}

charIndex = newCharIndex;