third_party/WebKit/Source/platform/fonts/shaping/CachingWordShaperTest.cpp - Issue 2386333002: reflow comments in platform/fonts

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/fonts/shaping/CachingWordShaperTest.cpp

Issue 2386333002: reflow comments in platform/fonts (Closed)

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/platform/fonts/GlyphMetricsMap.h ('K') | « third_party/WebKit/Source/platform/fonts/opentype/OpenTypeVerticalDataTest.cpp ('k') | third_party/WebKit/Source/platform/fonts/shaping/CaseMappingHarfBuzzBufferFiller.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/fonts/shaping/CachingWordShaperTest.cpp

diff --git a/third_party/WebKit/Source/platform/fonts/shaping/CachingWordShaperTest.cpp b/third_party/WebKit/Source/platform/fonts/shaping/CachingWordShaperTest.cpp

index fdb47ea0d05430a64d19fc9e545be7c2293efee7..f0daa5b30e9240452aba0d4323e79205d0f28ff5 100644

--- a/third_party/WebKit/Source/platform/fonts/shaping/CachingWordShaperTest.cpp

+++ b/third_party/WebKit/Source/platform/fonts/shaping/CachingWordShaperTest.cpp

@@ -449,10 +449,12 @@ TEST_F(CachingWordShaperTest, GlyphBoundsWithSpaces) {

float periodsAndSpacesWidth = shaper.width(&font, periodsAndSpaces, nullptr,

&periodsAndSpacesGlyphBounds);

- // The total width of periods and spaces should be longer than the width of periods alone.

+ // The total width of periods and spaces should be longer than the width of

+ // periods alone.

ASSERT_GT(periodsAndSpacesWidth, periodsWidth);

- // The glyph bounds of periods and spaces should be longer than the glyph bounds of periods alone.

+ // The glyph bounds of periods and spaces should be longer than the glyph

+ // bounds of periods alone.

ASSERT_GT(periodsAndSpacesGlyphBounds.width(), periodsGlyphBounds.width());

}