Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issue 2386273003: Keep the media controls panel visible if the overflow menu is visible. (Closed)

Created:
4 years, 2 months ago by mlamouri (slow - plz ping)
Modified:
4 years, 2 months ago
CC:
blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink, eric.carlson_apple.com, feature-media-reviews_chromium.org, fs, gasubic, mlamouri+watch-blink_chromium.org, nessy, Srirama, vcarbune.chromium
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Keep the media controls panel visible if the overflow menu is visible. Otherwise, the overflow menu stays visible while the controls are hidden which is fairly odd. Hiding the overflow menu would not be a good experience either because the timer to hide is fairly short. BUG=None R=zqzhang@chromium.org Committed: https://crrev.com/bb6df297d1d90181bb55ee9e50d2449070305644 Cr-Commit-Position: refs/heads/master@{#422764}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+88 lines, -5 lines) Patch
M third_party/WebKit/Source/core/html/shadow/MediaControls.h View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/shadow/MediaControls.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/shadow/MediaControlsTest.cpp View 6 chunks +84 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
mlamouri (slow - plz ping)
4 years, 2 months ago (2016-10-03 19:59:37 UTC) #3
Zhiqiang Zhang (Slow)
lgtm. The test is great!
4 years, 2 months ago (2016-10-04 11:08:30 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2386273003/1
4 years, 2 months ago (2016-10-04 12:25:23 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-04 12:30:35 UTC) #9
commit-bot: I haz the power
4 years, 2 months ago (2016-10-04 12:32:02 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bb6df297d1d90181bb55ee9e50d2449070305644
Cr-Commit-Position: refs/heads/master@{#422764}

Powered by Google App Engine
This is Rietveld 408576698