Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(481)

Unified Diff: third_party/WebKit/Source/core/html/shadow/MediaControls.cpp

Issue 2386273003: Keep the media controls panel visible if the overflow menu is visible. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/html/shadow/MediaControls.cpp
diff --git a/third_party/WebKit/Source/core/html/shadow/MediaControls.cpp b/third_party/WebKit/Source/core/html/shadow/MediaControls.cpp
index dc6d8f748a1f8fc3f69ce10a2a220ae7c3904c58..68e599a5166f92cf66e13372f810bd985b93c91d 100644
--- a/third_party/WebKit/Source/core/html/shadow/MediaControls.cpp
+++ b/third_party/WebKit/Source/core/html/shadow/MediaControls.cpp
@@ -391,8 +391,8 @@ bool MediaControls::shouldHideMediaControls(unsigned behaviorFlags) const {
if (!ignoreFocus &&
(mediaElement().focused() || contains(document().focusedElement())))
return false;
- // Don't hide the media controls when the text track list is showing.
- if (m_textTrackList->isWanted())
+ // Don't hide the media controls when a panel is showing.
+ if (m_textTrackList->isWanted() || m_overflowList->isWanted())
return false;
return true;
}

Powered by Google App Engine
This is Rietveld 408576698