Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(482)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2386253004: Enable goma on pdfium buildbots by default. (Closed)

Created:
4 years, 2 months ago by tikuta
Modified:
4 years, 2 months ago
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Enable goma on pdfium buildbots by default. This CL is reland of https://codereview.chromium.org/2380553002/ fix: Stop redirect stdout/stderr and remove close_fds=True https://codereview.chromium.org/2375843005/ BUG=643139 Committed: https://chromium.googlesource.com/chromium/tools/build/+/b66caa589fca0e42b535c0d7edc62eb6bf6764bd

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4476 lines, -72 lines) Patch
M scripts/slave/recipes/pdfium.py View 5 chunks +14 lines, -3 lines 0 comments Download
M scripts/slave/recipes/pdfium.expected/android.json View 2 chunks +194 lines, -3 lines 0 comments Download
M scripts/slave/recipes/pdfium.expected/drm_win_xfa.json View 4 chunks +194 lines, -3 lines 0 comments Download
M scripts/slave/recipes/pdfium.expected/linux.json View 3 chunks +194 lines, -3 lines 0 comments Download
M scripts/slave/recipes/pdfium.expected/linux_asan_lsan.json View 3 chunks +194 lines, -3 lines 0 comments Download
M scripts/slave/recipes/pdfium.expected/linux_no_v8.json View 3 chunks +194 lines, -3 lines 0 comments Download
M scripts/slave/recipes/pdfium.expected/linux_skia.json View 2 chunks +194 lines, -3 lines 0 comments Download
M scripts/slave/recipes/pdfium.expected/linux_xfa.json View 3 chunks +194 lines, -3 lines 0 comments Download
M scripts/slave/recipes/pdfium.expected/linux_xfa_asan_lsan.json View 3 chunks +194 lines, -3 lines 0 comments Download
M scripts/slave/recipes/pdfium.expected/linux_xfa_rel.json View 3 chunks +194 lines, -3 lines 0 comments Download
M scripts/slave/recipes/pdfium.expected/mac.json View 3 chunks +194 lines, -3 lines 0 comments Download
M scripts/slave/recipes/pdfium.expected/mac_no_v8.json View 3 chunks +194 lines, -3 lines 0 comments Download
M scripts/slave/recipes/pdfium.expected/mac_skia.json View 2 chunks +194 lines, -3 lines 0 comments Download
M scripts/slave/recipes/pdfium.expected/mac_xfa.json View 3 chunks +194 lines, -3 lines 0 comments Download
M scripts/slave/recipes/pdfium.expected/mac_xfa_rel.json View 3 chunks +194 lines, -3 lines 0 comments Download
M scripts/slave/recipes/pdfium.expected/try-linux_xfa_asan_lsan.json View 3 chunks +194 lines, -3 lines 0 comments Download
M scripts/slave/recipes/pdfium.expected/win.json View 3 chunks +194 lines, -3 lines 0 comments Download
M scripts/slave/recipes/pdfium.expected/win_no_v8.json View 3 chunks +194 lines, -3 lines 0 comments Download
M scripts/slave/recipes/pdfium.expected/win_skia.json View 2 chunks +194 lines, -3 lines 0 comments Download
M scripts/slave/recipes/pdfium.expected/win_xfa.json View 3 chunks +194 lines, -3 lines 0 comments Download
M scripts/slave/recipes/pdfium.expected/win_xfa_32.json View 3 chunks +194 lines, -3 lines 0 comments Download
M scripts/slave/recipes/pdfium.expected/win_xfa_clang.json View 3 chunks +194 lines, -3 lines 0 comments Download
M scripts/slave/recipes/pdfium.expected/win_xfa_clang_32.json View 3 chunks +194 lines, -3 lines 0 comments Download
M scripts/slave/recipes/pdfium.expected/win_xfa_rel.json View 3 chunks +194 lines, -3 lines 0 comments Download

Messages

Total messages: 16 (12 generated)
tikuta
I fixed the issue related to cloudtail on windows.
4 years, 2 months ago (2016-10-06 12:39:39 UTC) #9
Dirk Pranke
lgtm
4 years, 2 months ago (2016-10-06 16:56:51 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2386253004/20001
4 years, 2 months ago (2016-10-07 02:08:57 UTC) #14
commit-bot: I haz the power
4 years, 2 months ago (2016-10-07 02:13:19 UTC) #16
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/tools/build/+/b66caa589fca0e42b535...

Powered by Google App Engine
This is Rietveld 408576698