Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Unified Diff: third_party/WebKit/Source/platform/speech/PlatformSpeechSynthesizer.h

Issue 2386203002: Reflow comments in Source/modules/speech and platform/speech (Closed)
Patch Set: Do platform/speech too Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/speech/PlatformSpeechSynthesizer.h
diff --git a/third_party/WebKit/Source/platform/speech/PlatformSpeechSynthesizer.h b/third_party/WebKit/Source/platform/speech/PlatformSpeechSynthesizer.h
index a240cfe7b13aa8897e82c722fb8dc24be3728d09..2f838320c026125046a8cdea6d842d7b17ab5175 100644
--- a/third_party/WebKit/Source/platform/speech/PlatformSpeechSynthesizer.h
+++ b/third_party/WebKit/Source/platform/speech/PlatformSpeechSynthesizer.h
@@ -80,12 +80,16 @@ class PLATFORM_EXPORT PlatformSpeechSynthesizer
void setVoiceList(Vector<RefPtr<PlatformSpeechSynthesisVoice>>&);
- // Eager finalization is required to promptly release the owned WebSpeechSynthesizer.
+ // Eager finalization is required to promptly release the owned
+ // WebSpeechSynthesizer.
//
- // If not and delayed until lazily swept, m_webSpeechSynthesizerClient may end up
- // being lazily swept first (i.e., before this PlatformSpeechSynthesizer), leaving
+ // If not and delayed until lazily swept, m_webSpeechSynthesizerClient may end
+ // up
Nico 2016/10/03 17:03:03 this needs lots of reflowing (hit gq a few times)
hans 2016/10/03 17:33:54 Done.
+ // being lazily swept first (i.e., before this PlatformSpeechSynthesizer),
+ // leaving
// m_webSpeechSynthesizer with a dangling pointer to a finalized object --
- // WebSpeechSynthesizer embedder implementations calling notification methods in the
+ // WebSpeechSynthesizer embedder implementations calling notification methods
+ // in the
// other directions by way of m_webSpeechSynthesizerClient. Eagerly releasing
// WebSpeechSynthesizer prevents such unsafe accesses.
EAGERLY_FINALIZE();

Powered by Google App Engine
This is Rietveld 408576698