third_party/WebKit/Source/modules/speech/SpeechSynthesisUtterance.cpp - Issue 2386203002: Reflow comments in Source/modules/speech and platform/speech

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/speech/SpeechSynthesisUtterance.cpp

Issue 2386203002: Reflow comments in Source/modules/speech and platform/speech (Closed)

Patch Set: Do platform/speech too Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/modules/speech/SpeechSynthesis.cpp ('K') | « third_party/WebKit/Source/modules/speech/SpeechSynthesis.cpp ('k') | third_party/WebKit/Source/modules/speech/testing/PlatformSpeechSynthesizerMock.cpp » ('j') | third_party/WebKit/Source/platform/speech/PlatformSpeechSynthesizer.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/speech/SpeechSynthesisUtterance.cpp

diff --git a/third_party/WebKit/Source/modules/speech/SpeechSynthesisUtterance.cpp b/third_party/WebKit/Source/modules/speech/SpeechSynthesisUtterance.cpp

index 8b0c2c7dfa2302843397d22d4e04d7b827d87d6a..e58883dc7ba2b94bf913dcc33ce50d5abe7fc6c1 100644

--- a/third_party/WebKit/Source/modules/speech/SpeechSynthesisUtterance.cpp

+++ b/third_party/WebKit/Source/modules/speech/SpeechSynthesisUtterance.cpp

@@ -55,8 +55,10 @@ SpeechSynthesisVoice* SpeechSynthesisUtterance::voice() const {

}

void SpeechSynthesisUtterance::setVoice(SpeechSynthesisVoice* voice) {

- // Cache our own version of the SpeechSynthesisVoice so that we don't have to do some lookup

- // to go from the platform voice back to the speech synthesis voice in the read property.

+ // Cache our own version of the SpeechSynthesisVoice so that we don't have to

+ // do some lookup

+ // to go from the platform voice back to the speech synthesis voice in the

Nico 2016/10/03 17:03:02 put on previous line

hans 2016/10/03 17:33:54 Done.

+ // read property.

m_voice = voice;

if (voice)