Chromium Code Reviews| Index: third_party/WebKit/Source/platform/speech/PlatformSpeechSynthesizer.h |
| diff --git a/third_party/WebKit/Source/platform/speech/PlatformSpeechSynthesizer.h b/third_party/WebKit/Source/platform/speech/PlatformSpeechSynthesizer.h |
| index a240cfe7b13aa8897e82c722fb8dc24be3728d09..2f838320c026125046a8cdea6d842d7b17ab5175 100644 |
| --- a/third_party/WebKit/Source/platform/speech/PlatformSpeechSynthesizer.h |
| +++ b/third_party/WebKit/Source/platform/speech/PlatformSpeechSynthesizer.h |
| @@ -80,12 +80,16 @@ class PLATFORM_EXPORT PlatformSpeechSynthesizer |
| void setVoiceList(Vector<RefPtr<PlatformSpeechSynthesisVoice>>&); |
| - // Eager finalization is required to promptly release the owned WebSpeechSynthesizer. |
| + // Eager finalization is required to promptly release the owned |
| + // WebSpeechSynthesizer. |
| // |
| - // If not and delayed until lazily swept, m_webSpeechSynthesizerClient may end up |
| - // being lazily swept first (i.e., before this PlatformSpeechSynthesizer), leaving |
| + // If not and delayed until lazily swept, m_webSpeechSynthesizerClient may end |
| + // up |
|
Nico
2016/10/03 17:03:03
this needs lots of reflowing (hit gq a few times)
hans
2016/10/03 17:33:54
Done.
|
| + // being lazily swept first (i.e., before this PlatformSpeechSynthesizer), |
| + // leaving |
| // m_webSpeechSynthesizer with a dangling pointer to a finalized object -- |
| - // WebSpeechSynthesizer embedder implementations calling notification methods in the |
| + // WebSpeechSynthesizer embedder implementations calling notification methods |
| + // in the |
| // other directions by way of m_webSpeechSynthesizerClient. Eagerly releasing |
| // WebSpeechSynthesizer prevents such unsafe accesses. |
| EAGERLY_FINALIZE(); |