Make all PermissionDecisionAutoBlocker methods static.

Make all PermissionDecisionAutoBlocker methods static.

This avoids having to instantiate an object every time RecordIgnore is
called.

PermissionDecisionAutoBlocker::RecordDismiss is also split out from
PermissionDecisionAutoBlocker::ShouldChangeDismissalToBlock.

BUG=638076
Committed: https://crrev.com/423c3044abad2ac900c31cda5b2f368417b6d6e0
Cr-Commit-Position: refs/heads/master@{#423084}

[dominickn, 2016-10-04 05:04:55]

The CQ bit was checked by dominickn@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-04 05:05:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dominickn, 2016-10-04 05:10:20]

dominickn@chromium.org changed reviewers:
+ kcarattini@chromium.org, raymes@chromium.org

[dominickn, 2016-10-04 05:10:21]

PTAL, thanks!

[kcarattini, 2016-10-04 05:26:05]

lgtm

Nice cleanup, thanks!

https://codereview.chromium.org/2386193004/diff/1/chrome/browser/permissions/...
File chrome/browser/permissions/permission_context_base.cc (right):

https://codereview.chromium.org/2386193004/diff/1/chrome/browser/permissions/...
chrome/browser/permissions/permission_context_base.cc:58:
PermissionDecisionAutoBlocker::UpdateFromVariations();
How often do you expect the value to change? You could alternatively call this
at the top of each of the  PermissionDecisionAutoBlocker static methods to
ensure they use the most up-to-date value. Might be overkill if that's not so
important.

https://codereview.chromium.org/2386193004/diff/1/chrome/browser/permissions/...
File chrome/browser/permissions/permission_decision_auto_blocker.cc (right):

https://codereview.chromium.org/2386193004/diff/1/chrome/browser/permissions/...
chrome/browser/permissions/permission_decision_auto_blocker.cc:26: int
g_PromptDismissalsBeforeBlock = 3;
Aren't globals lowercase with underscores?

[commit-bot: I haz the power, 2016-10-04 05:43:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-04 05:43:11]

Dry run: This issue passed the CQ dry run.

[dominickn, 2016-10-04 06:18:53]

dominickn@chromium.org changed reviewers:
+ msramek@chromium.org

[dominickn, 2016-10-04 06:18:54]

+msramek: PTAL at the browsing data remover, thanks!

https://codereview.chromium.org/2386193004/diff/1/chrome/browser/permissions/...
File chrome/browser/permissions/permission_context_base.cc (right):

https://codereview.chromium.org/2386193004/diff/1/chrome/browser/permissions/...
chrome/browser/permissions/permission_context_base.cc:58:
PermissionDecisionAutoBlocker::UpdateFromVariations();
On 2016/10/04 05:26:05, kcarattini wrote:
> How often do you expect the value to change? You could alternatively call this
> at the top of each of the  PermissionDecisionAutoBlocker static methods to
> ensure they use the most up-to-date value. Might be overkill if that's not so
> important.

I think having it within PermissionContextBase makes the most amount of sense
overhead-wise. This shouldn't change all that often, but we need to call it more
often than browser startup for people who restart rarely.

[msramek, 2016-10-04 08:17:34]

browsing_data/ LGTM

[raymes, 2016-10-05 05:02:32]

lgtm

Thanks Dom!

https://codereview.chromium.org/2386193004/diff/1/chrome/browser/permissions/...
File chrome/browser/permissions/permission_context_base.cc (right):

https://codereview.chromium.org/2386193004/diff/1/chrome/browser/permissions/...
chrome/browser/permissions/permission_context_base.cc:58:
PermissionDecisionAutoBlocker::UpdateFromVariations();
On 2016/10/04 06:18:54, dominickn wrote:
> On 2016/10/04 05:26:05, kcarattini wrote:
> > How often do you expect the value to change? You could alternatively call
this
> > at the top of each of the  PermissionDecisionAutoBlocker static methods to
> > ensure they use the most up-to-date value. Might be overkill if that's not
so
> > important.
> 
> I think having it within PermissionContextBase makes the most amount of sense
> overhead-wise. This shouldn't change all that often, but we need to call it
more
> often than browser startup for people who restart rarely.

This will only really happen once at browser (profile) startup. Maybe that's
good enough though.

https://codereview.chromium.org/2386193004/diff/1/chrome/browser/permissions/...
File chrome/browser/permissions/permission_decision_auto_blocker.cc (right):

https://codereview.chromium.org/2386193004/diff/1/chrome/browser/permissions/...
chrome/browser/permissions/permission_decision_auto_blocker.cc:26: int
g_PromptDismissalsBeforeBlock = 3;
On 2016/10/04 05:26:05, kcarattini wrote:
> Aren't globals lowercase with underscores?

+1

https://codereview.chromium.org/2386193004/diff/1/chrome/browser/permissions/...
File chrome/browser/permissions/permission_decision_auto_blocker.h (right):

https://codereview.chromium.org/2386193004/diff/1/chrome/browser/permissions/...
chrome/browser/permissions/permission_decision_auto_blocker.h:50: // Updates the
number of prompts before blocking.
nit: Updates the threshold at which to start blocking prompts from the field
trial.

https://codereview.chromium.org/2386193004/diff/1/chrome/browser/permissions/...
chrome/browser/permissions/permission_decision_auto_blocker.h:53: private:
nit: DISALLOW_IMPLICIT_CONSTRUCTORS

[dominickn, 2016-10-05 05:19:53]

The CQ bit was checked by dominickn@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-05 05:20:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-05 05:54:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-05 05:54:44]

Dry run: This issue passed the CQ dry run.

[dominickn, 2016-10-05 05:55:30]

Thanks!

https://codereview.chromium.org/2386193004/diff/1/chrome/browser/permissions/...
File chrome/browser/permissions/permission_context_base.cc (right):

https://codereview.chromium.org/2386193004/diff/1/chrome/browser/permissions/...
chrome/browser/permissions/permission_context_base.cc:58:
PermissionDecisionAutoBlocker::UpdateFromVariations();
On 2016/10/05 05:02:32, raymes wrote:
> On 2016/10/04 06:18:54, dominickn wrote:
> > On 2016/10/04 05:26:05, kcarattini wrote:
> > > How often do you expect the value to change? You could alternatively call
> this
> > > at the top of each of the  PermissionDecisionAutoBlocker static methods to
> > > ensure they use the most up-to-date value. Might be overkill if that's not
> so
> > > important.
> > 
> > I think having it within PermissionContextBase makes the most amount of
sense
> > overhead-wise. This shouldn't change all that often, but we need to call it
> more
> > often than browser startup for people who restart rarely.
> 
> This will only really happen once at browser (profile) startup. Maybe that's
> good enough though.

Acknowledged.

https://codereview.chromium.org/2386193004/diff/1/chrome/browser/permissions/...
File chrome/browser/permissions/permission_decision_auto_blocker.cc (right):

https://codereview.chromium.org/2386193004/diff/1/chrome/browser/permissions/...
chrome/browser/permissions/permission_decision_auto_blocker.cc:26: int
g_PromptDismissalsBeforeBlock = 3;
On 2016/10/05 05:02:32, raymes wrote:
> On 2016/10/04 05:26:05, kcarattini wrote:
> > Aren't globals lowercase with underscores?
> 
> +1

Done, though we do seem to have a consistency issue in the codebase.

https://codereview.chromium.org/2386193004/diff/1/chrome/browser/permissions/...
File chrome/browser/permissions/permission_decision_auto_blocker.h (right):

https://codereview.chromium.org/2386193004/diff/1/chrome/browser/permissions/...
chrome/browser/permissions/permission_decision_auto_blocker.h:50: // Updates the
number of prompts before blocking.
On 2016/10/05 05:02:32, raymes wrote:
> nit: Updates the threshold at which to start blocking prompts from the field
> trial.

Done.

https://codereview.chromium.org/2386193004/diff/1/chrome/browser/permissions/...
chrome/browser/permissions/permission_decision_auto_blocker.h:53: private:
On 2016/10/05 05:02:32, raymes wrote:
> nit: DISALLOW_IMPLICIT_CONSTRUCTORS

Done.

[dominickn, 2016-10-05 05:55:37]

The CQ bit was checked by dominickn@chromium.org

[dominickn, 2016-10-05 05:55:38]

The patchset sent to the CQ was uploaded after l-g-t-m from
msramek@chromium.org, kcarattini@chromium.org, raymes@chromium.org
Link to the patchset: https://codereview.chromium.org/2386193004/#ps20001
(title: "Address comments")

[commit-bot: I haz the power, 2016-10-05 05:55:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-05 06:00:00]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-10-05 06:01:34]

Description was changed from

==========
Make all PermissionDecisionAutoBlocker methods static.

This avoids having to instantiate an object every time RecordIgnore is
called.

PermissionDecisionAutoBlocker::RecordDismiss is also split out from
PermissionDecisionAutoBlocker::ShouldChangeDismissalToBlock.

BUG=638076
==========

to

==========
Make all PermissionDecisionAutoBlocker methods static.

This avoids having to instantiate an object every time RecordIgnore is
called.

PermissionDecisionAutoBlocker::RecordDismiss is also split out from
PermissionDecisionAutoBlocker::ShouldChangeDismissalToBlock.

BUG=638076

Committed: https://crrev.com/423c3044abad2ac900c31cda5b2f368417b6d6e0
Cr-Commit-Position: refs/heads/master@{#423084}
==========

[commit-bot: I haz the power, 2016-10-05 06:01:36]

Patchset 2 (id:??) landed as
https://crrev.com/423c3044abad2ac900c31cda5b2f368417b6d6e0
Cr-Commit-Position: refs/heads/master@{#423084}