Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Issue 2386193004: Make all PermissionDecisionAutoBlocker methods static. (Closed)

Created:
4 years, 2 months ago by dominickn
Modified:
4 years, 2 months ago
Reviewers:
msramek, kcarattini, raymes
CC:
chromium-reviews, mlamouri+watch-permissions_chromium.org, markusheintz_, msramek+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make all PermissionDecisionAutoBlocker methods static. This avoids having to instantiate an object every time RecordIgnore is called. PermissionDecisionAutoBlocker::RecordDismiss is also split out from PermissionDecisionAutoBlocker::ShouldChangeDismissalToBlock. BUG=638076 Committed: https://crrev.com/423c3044abad2ac900c31cda5b2f368417b6d6e0 Cr-Commit-Position: refs/heads/master@{#423084}

Patch Set 1 #

Total comments: 11

Patch Set 2 : Address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -45 lines) Patch
M chrome/browser/browsing_data/browsing_data_remover_unittest.cc View 1 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/permissions/permission_context_base.h View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/browser/permissions/permission_context_base.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/permissions/permission_decision_auto_blocker.h View 1 3 chunks +16 lines, -11 lines 0 comments Download
M chrome/browser/permissions/permission_decision_auto_blocker.cc View 1 2 chunks +22 lines, -15 lines 0 comments Download
M chrome/browser/permissions/permission_decision_auto_blocker_unittest.cc View 1 chunk +4 lines, -6 lines 0 comments Download
M chrome/browser/permissions/permission_request_impl.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/permissions/permission_uma_util.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 22 (13 generated)
dominickn
PTAL, thanks!
4 years, 2 months ago (2016-10-04 05:10:21 UTC) #4
kcarattini
lgtm Nice cleanup, thanks! https://codereview.chromium.org/2386193004/diff/1/chrome/browser/permissions/permission_context_base.cc File chrome/browser/permissions/permission_context_base.cc (right): https://codereview.chromium.org/2386193004/diff/1/chrome/browser/permissions/permission_context_base.cc#newcode58 chrome/browser/permissions/permission_context_base.cc:58: PermissionDecisionAutoBlocker::UpdateFromVariations(); How often do you ...
4 years, 2 months ago (2016-10-04 05:26:05 UTC) #5
dominickn
+msramek: PTAL at the browsing data remover, thanks! https://codereview.chromium.org/2386193004/diff/1/chrome/browser/permissions/permission_context_base.cc File chrome/browser/permissions/permission_context_base.cc (right): https://codereview.chromium.org/2386193004/diff/1/chrome/browser/permissions/permission_context_base.cc#newcode58 chrome/browser/permissions/permission_context_base.cc:58: PermissionDecisionAutoBlocker::UpdateFromVariations(); ...
4 years, 2 months ago (2016-10-04 06:18:54 UTC) #9
msramek
browsing_data/ LGTM
4 years, 2 months ago (2016-10-04 08:17:34 UTC) #10
raymes
lgtm Thanks Dom! https://codereview.chromium.org/2386193004/diff/1/chrome/browser/permissions/permission_context_base.cc File chrome/browser/permissions/permission_context_base.cc (right): https://codereview.chromium.org/2386193004/diff/1/chrome/browser/permissions/permission_context_base.cc#newcode58 chrome/browser/permissions/permission_context_base.cc:58: PermissionDecisionAutoBlocker::UpdateFromVariations(); On 2016/10/04 06:18:54, dominickn wrote: ...
4 years, 2 months ago (2016-10-05 05:02:32 UTC) #11
dominickn
Thanks! https://codereview.chromium.org/2386193004/diff/1/chrome/browser/permissions/permission_context_base.cc File chrome/browser/permissions/permission_context_base.cc (right): https://codereview.chromium.org/2386193004/diff/1/chrome/browser/permissions/permission_context_base.cc#newcode58 chrome/browser/permissions/permission_context_base.cc:58: PermissionDecisionAutoBlocker::UpdateFromVariations(); On 2016/10/05 05:02:32, raymes wrote: > On ...
4 years, 2 months ago (2016-10-05 05:55:30 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2386193004/20001
4 years, 2 months ago (2016-10-05 05:55:58 UTC) #19
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-05 06:00:00 UTC) #20
commit-bot: I haz the power
4 years, 2 months ago (2016-10-05 06:01:36 UTC) #22
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/423c3044abad2ac900c31cda5b2f368417b6d6e0
Cr-Commit-Position: refs/heads/master@{#423084}

Powered by Google App Engine
This is Rietveld 408576698