Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(971)

Unified Diff: chrome/browser/permissions/permission_context_base.cc

Issue 2386193004: Make all PermissionDecisionAutoBlocker methods static. (Closed)
Patch Set: Address comments Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/permissions/permission_context_base.cc
diff --git a/chrome/browser/permissions/permission_context_base.cc b/chrome/browser/permissions/permission_context_base.cc
index 8e0e4ee83e3697a44fe5870c92d1c88955b8ffd9..92909556a1819b10add64a542004958fb5ea1287 100644
--- a/chrome/browser/permissions/permission_context_base.cc
+++ b/chrome/browser/permissions/permission_context_base.cc
@@ -48,7 +48,6 @@ PermissionContextBase::PermissionContextBase(
const content::PermissionType permission_type,
const ContentSettingsType content_settings_type)
: profile_(profile),
- decision_auto_blocker_(new PermissionDecisionAutoBlocker(profile)),
permission_type_(permission_type),
content_settings_type_(content_settings_type),
weak_factory_(this) {
@@ -56,6 +55,7 @@ PermissionContextBase::PermissionContextBase(
permission_queue_controller_.reset(new PermissionQueueController(
profile_, permission_type_, content_settings_type_));
#endif
+ PermissionDecisionAutoBlocker::UpdateFromVariations();
}
PermissionContextBase::~PermissionContextBase() {
@@ -238,8 +238,8 @@ void PermissionContextBase::PermissionDecided(
// Check if we should convert a dismiss decision into a block decision. This
// is gated on enabling the kBlockPromptsIfDismissedOften feature.
if (content_setting == CONTENT_SETTING_DEFAULT &&
- decision_auto_blocker_->ShouldChangeDismissalToBlock(requesting_origin,
- permission_type_)) {
+ PermissionDecisionAutoBlocker::ShouldChangeDismissalToBlock(
+ requesting_origin, permission_type_, profile_)) {
persist = true;
content_setting = CONTENT_SETTING_BLOCK;
}
« no previous file with comments | « chrome/browser/permissions/permission_context_base.h ('k') | chrome/browser/permissions/permission_decision_auto_blocker.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698