Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2386183002: Replace manual conversions with Mojo type mappings

Created:
4 years, 2 months ago by chfremer
Modified:
4 years, 2 months ago
Reviewers:
CC:
chromium-reviews, qsr+mojo_chromium.org, Aaron Boodman, posciak+watch_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, feature-media-reviews_chromium.org, mcasas+watch+vc_chromium.org, darin (slow to review), miu+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace manual conversions with Mojo type mappings This is not yet up for review. This is FYI only. This is CL1.9.3 in the context of Mojo Video Capture [1] [1] https://docs.google.com/a/chromium.org/document/d/1Qw7rw1AJy0QHXjha36jZNiEuxsxWslJ_X-zpOhijvI8/edit?usp=sharing

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+421 lines, -325 lines) Patch
M media/capture/video/video_capture_device_descriptor.h View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/public/tools/bindings/chromium_bindings_configuration.gni View 1 chunk +1 line, -0 lines 0 comments Download
M services/video_capture/BUILD.gn View 2 chunks +1 line, -2 lines 0 comments Download
M services/video_capture/DEPS View 1 chunk +2 lines, -0 lines 0 comments Download
M services/video_capture/device_factory_media_to_mojo_adapter.h View 1 chunk +2 lines, -2 lines 0 comments Download
M services/video_capture/device_factory_media_to_mojo_adapter.cc View 3 chunks +12 lines, -25 lines 0 comments Download
M services/video_capture/fake_device_descriptor_test.h View 1 chunk +1 line, -1 line 0 comments Download
M services/video_capture/fake_device_descriptor_test.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M services/video_capture/fake_device_descriptor_unittest.cc View 3 chunks +11 lines, -12 lines 0 comments Download
M services/video_capture/fake_device_test.h View 1 chunk +2 lines, -2 lines 0 comments Download
M services/video_capture/fake_device_test.cc View 1 chunk +9 lines, -10 lines 0 comments Download
M services/video_capture/fake_device_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M services/video_capture/mock_device_descriptor_receiver.h View 2 chunks +2 lines, -6 lines 0 comments Download
M services/video_capture/mock_device_descriptor_receiver.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M services/video_capture/mock_device_factory.h View 1 chunk +1 line, -1 line 0 comments Download
M services/video_capture/mock_device_factory.cc View 2 chunks +2 lines, -5 lines 0 comments Download
M services/video_capture/mock_device_test.h View 1 chunk +1 line, -1 line 0 comments Download
M services/video_capture/mock_device_test.cc View 2 chunks +11 lines, -14 lines 0 comments Download
M services/video_capture/mock_supported_formats_receiver.h View 1 chunk +1 line, -5 lines 0 comments Download
M services/video_capture/mock_supported_formats_receiver.cc View 1 chunk +0 lines, -5 lines 0 comments Download
D services/video_capture/mojo_media_conversions.h View 1 chunk +0 lines, -39 lines 0 comments Download
D services/video_capture/mojo_media_conversions.cc View 1 chunk +0 lines, -162 lines 0 comments Download
A + services/video_capture/public/interfaces/typemaps.gni View 1 chunk +2 lines, -2 lines 0 comments Download
A services/video_capture/public/interfaces/video_capture_device_descriptor.typemap View 1 chunk +11 lines, -0 lines 0 comments Download
A services/video_capture/public/interfaces/video_capture_device_descriptor_struct_traits.h View 1 chunk +172 lines, -0 lines 0 comments Download
A services/video_capture/public/interfaces/video_capture_settings.typemap View 1 chunk +15 lines, -0 lines 0 comments Download
A services/video_capture/public/interfaces/video_capture_settings_struct_traits.h View 1 chunk +145 lines, -0 lines 0 comments Download
M services/video_capture/receiver_mojo_to_media_adapter.h View 2 chunks +0 lines, -5 lines 0 comments Download
M services/video_capture/video_capture_device_proxy_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M services/video_capture/video_capture_device_proxy_impl.cc View 2 chunks +1 line, -2 lines 0 comments Download
M services/video_capture/video_capture_service.h View 1 chunk +1 line, -1 line 0 comments Download
M services/video_capture/video_capture_service.cc View 2 chunks +1 line, -2 lines 0 comments Download
M services/video_capture/video_capture_service_unittest.cc View 3 chunks +6 lines, -7 lines 0 comments Download

Messages

Total messages: 1 (1 generated)
chfremer
4 years, 2 months ago (2016-10-03 16:24:26 UTC) #1 
Description was changed from

==========
fix presubmit


Merge branch '1.9.1' into 1.9.3


* Fix error in conversion code causing test failures * Remove unused field and
forward declaration


Replace manual conversions with Mojo typemappings

BUG=
==========

to

==========
Replace manual conversions with Mojo type mappings

This is not yet up for review.
This is FYI only.

This is CL1.9.3 in the context of Mojo Video Capture [1]

[1]
https://docs.google.com/a/chromium.org/document/d/1Qw7rw1AJy0QHXjha36jZNiEuxs...
==========

Powered by Google App Engine
This is Rietveld 408576698