Replace manual conversions with Mojo type mappings

services/video_capture/fake_device_descriptor_unittest.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/run_loop.h"
 #include "services/video_capture/fake_device_descriptor_test.h"
 #include "services/video_capture/mock_video_frame_receiver.h"
 
 using testing::_;
 using testing::InvokeWithoutArgs;
 
 namespace video_capture {
 
 class MockCreateDeviceProxyCallback {
  public:
   MOCK_METHOD1(Run, void(mojom::DeviceAccessResultCode result_code));
 };
 
 // Tests that when requesting a second proxy for a device without closing the
 // first one, the service revokes access to the first one by closing the
 // connection.
 TEST_F(FakeDeviceDescriptorTest, AccessIsRevokedOnSecondAccess) {
   mojom::VideoCaptureDeviceProxyPtr device_proxy_1;
   bool device_access_1_revoked = false;
   MockCreateDeviceProxyCallback create_device_proxy_callback_1;
   EXPECT_CALL(create_device_proxy_callback_1,
               Run(mojom::DeviceAccessResultCode::SUCCESS))
       .Times(1);
   factory_->CreateDeviceProxy(
-      fake_device_descriptor_->Clone(), mojo::GetProxy(&device_proxy_1),
+      fake_device_descriptor_, mojo::GetProxy(&device_proxy_1),
       base::Bind(&MockCreateDeviceProxyCallback::Run,
                  base::Unretained(&create_device_proxy_callback_1)));
   device_proxy_1.set_connection_error_handler(
       base::Bind([](bool* access_revoked) { *access_revoked = true; },
                  &device_access_1_revoked));
 
   base::RunLoop wait_loop;
   mojom::VideoCaptureDeviceProxyPtr device_proxy_2;
   bool device_access_2_revoked = false;
   MockCreateDeviceProxyCallback create_device_proxy_callback_2;
   EXPECT_CALL(create_device_proxy_callback_2,
               Run(mojom::DeviceAccessResultCode::SUCCESS))
       .Times(1)
       .WillOnce(InvokeWithoutArgs([&wait_loop]() { wait_loop.Quit(); }));
   factory_->CreateDeviceProxy(
-      fake_device_descriptor_->Clone(), mojo::GetProxy(&device_proxy_2),
+      fake_device_descriptor_, mojo::GetProxy(&device_proxy_2),
       base::Bind(&MockCreateDeviceProxyCallback::Run,
                  base::Unretained(&create_device_proxy_callback_2)));
   device_proxy_2.set_connection_error_handler(
       base::Bind([](bool* access_revoked) { *access_revoked = true; },
                  &device_access_2_revoked));
   wait_loop.Run();
   ASSERT_TRUE(device_access_1_revoked);
   ASSERT_FALSE(device_access_2_revoked);
 }
 
 // Tests that a second proxy requested for a device can be used successfully.
 TEST_F(FakeDeviceDescriptorTest, CanUseSecondRequestedProxy) {
   mojom::VideoCaptureDeviceProxyPtr device_proxy_1;
   factory_->CreateDeviceProxy(
-      fake_device_descriptor_->Clone(), mojo::GetProxy(&device_proxy_1),
+      fake_device_descriptor_, mojo::GetProxy(&device_proxy_1),
       base::Bind([](mojom::DeviceAccessResultCode result_code) {}));
 
   base::RunLoop wait_loop;
   mojom::VideoCaptureDeviceProxyPtr device_proxy_2;
   factory_->CreateDeviceProxy(
-      fake_device_descriptor_->Clone(), mojo::GetProxy(&device_proxy_2),
+      fake_device_descriptor_, mojo::GetProxy(&device_proxy_2),
       base::Bind(
           [](base::RunLoop* wait_loop,
              mojom::DeviceAccessResultCode result_code) { wait_loop->Quit(); },
           &wait_loop));
   wait_loop.Run();
 
-  auto arbitrary_requested_settings = mojom::VideoCaptureSettings::New();
-  arbitrary_requested_settings->format = mojom::VideoCaptureFormat::New();
-  arbitrary_requested_settings->format->frame_size.SetSize(640, 480);
-  arbitrary_requested_settings->format->frame_rate = 15;
-  arbitrary_requested_settings->resolution_change_policy =
-      mojom::ResolutionChangePolicy::FIXED_RESOLUTION;
-  arbitrary_requested_settings->power_line_frequency =
-      mojom::PowerLineFrequency::DEFAULT;
+  media::VideoCaptureParams arbitrary_requested_settings;
+  arbitrary_requested_settings.requested_format.frame_size.SetSize(640, 480);
+  arbitrary_requested_settings.requested_format.frame_rate = 15;
+  arbitrary_requested_settings.resolution_change_policy =
+      media::RESOLUTION_POLICY_FIXED_RESOLUTION;
+  arbitrary_requested_settings.power_line_frequency =
+      media::PowerLineFrequency::FREQUENCY_DEFAULT;
 
   base::RunLoop wait_loop_2;
   mojom::VideoFrameReceiverPtr receiver_proxy;
   MockVideoFrameReceiver receiver(mojo::GetProxy(&receiver_proxy));
   EXPECT_CALL(receiver, OnIncomingCapturedVideoFramePtr(_))
       .WillRepeatedly(
           InvokeWithoutArgs([&wait_loop_2]() { wait_loop_2.Quit(); }));
 
   device_proxy_2->Start(std::move(arbitrary_requested_settings),
                         std::move(receiver_proxy));
   wait_loop_2.Run();
 }
 
 }  // namespace video_capture