Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2386093002:
perf: Re-enable smoothness.tough_ad_cases on Android (Closed)
|
Created:
4 years, 2 months ago by Sami Modified:
4 years, 2 months ago Reviewers:
alex clarke (OOO till 29th) CC:
chromium-reviews, telemetry-reviews_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Descriptionperf: Re-enable smoothness.tough_ad_cases on Android
These benchmarks were failing for the same underlying reason as
smoothness.tough_webgl_ad_cases, which was fixed by
https://codereview.chromium.org/2373983005.
BUG=647413
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq
Committed: https://crrev.com/e86c7afce17c0a263c19406eb3bb68bbc70b6b71
Cr-Commit-Position: refs/heads/master@{#422754}
Patch Set 1 #
Messages
Total messages: 23 (14 generated)
Description was changed from ========== perf: Re-enable smoothness.tough_ad_cases on Android These benchmarks were failing for the same underlying reason as smoothness.tough_webgl_ad_cases, which was fixed by https://codereview.chromium.org/2373983005. BUG=647413 ========== to ========== perf: Re-enable smoothness.tough_ad_cases on Android These benchmarks were failing for the same underlying reason as smoothness.tough_webgl_ad_cases, which was fixed by https://codereview.chromium.org/2373983005. BUG=647413 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq ==========
The CQ bit was checked by skyostil@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== perf: Re-enable smoothness.tough_ad_cases on Android These benchmarks were failing for the same underlying reason as smoothness.tough_webgl_ad_cases, which was fixed by https://codereview.chromium.org/2373983005. BUG=647413 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq ========== to ========== perf: Re-enable smoothness.tough_ad_cases on Android These benchmarks were failing for the same underlying reason as smoothness.tough_webgl_ad_cases, which was fixed by https://codereview.chromium.org/2373983005. BUG=647413 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq ==========
skyostil@chromium.org changed reviewers: + alexclarke@chromium.org
lgtm
The CQ bit was unchecked by skyostil@chromium.org
The CQ bit was checked by skyostil@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Exceeded global retry quota
The CQ bit was checked by skyostil@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Exceeded global retry quota
Description was changed from ========== perf: Re-enable smoothness.tough_ad_cases on Android These benchmarks were failing for the same underlying reason as smoothness.tough_webgl_ad_cases, which was fixed by https://codereview.chromium.org/2373983005. BUG=647413 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq ========== to ========== perf: Re-enable smoothness.tough_ad_cases on Android These benchmarks were failing for the same underlying reason as smoothness.tough_webgl_ad_cases, which was fixed by https://codereview.chromium.org/2373983005. BUG=647413 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq ==========
The CQ bit was checked by skyostil@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== perf: Re-enable smoothness.tough_ad_cases on Android These benchmarks were failing for the same underlying reason as smoothness.tough_webgl_ad_cases, which was fixed by https://codereview.chromium.org/2373983005. BUG=647413 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq ========== to ========== perf: Re-enable smoothness.tough_ad_cases on Android These benchmarks were failing for the same underlying reason as smoothness.tough_webgl_ad_cases, which was fixed by https://codereview.chromium.org/2373983005. BUG=647413 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== perf: Re-enable smoothness.tough_ad_cases on Android These benchmarks were failing for the same underlying reason as smoothness.tough_webgl_ad_cases, which was fixed by https://codereview.chromium.org/2373983005. BUG=647413 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq ========== to ========== perf: Re-enable smoothness.tough_ad_cases on Android These benchmarks were failing for the same underlying reason as smoothness.tough_webgl_ad_cases, which was fixed by https://codereview.chromium.org/2373983005. BUG=647413 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq Committed: https://crrev.com/e86c7afce17c0a263c19406eb3bb68bbc70b6b71 Cr-Commit-Position: refs/heads/master@{#422754} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/e86c7afce17c0a263c19406eb3bb68bbc70b6b71 Cr-Commit-Position: refs/heads/master@{#422754} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
