Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(582)

Issue 2373983005: perf: Speculative fix for Swiffy WebGL ad pages (Closed)

Created:
4 years, 2 months ago by Sami
Modified:
4 years, 2 months ago
CC:
chromium-reviews, telemetry-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

perf: Speculative fix for Swiffy WebGL ad pages Sometimes we try to set up the viewport on the page before the page has fully loaded. Wait for the page to settle before doing this. BUG=647413 Committed: https://crrev.com/c320e4b3fdb478bcac243cade43f115abb768b4a Cr-Commit-Position: refs/heads/master@{#422081}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M tools/perf/page_sets/tough_ad_cases.py View 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Sami
4 years, 2 months ago (2016-09-30 09:58:15 UTC) #3
alex clarke (OOO till 29th)
lgtm
4 years, 2 months ago (2016-09-30 10:01:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2373983005/1
4 years, 2 months ago (2016-09-30 10:05:54 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-30 11:18:41 UTC) #8
commit-bot: I haz the power
4 years, 2 months ago (2016-09-30 11:20:57 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c320e4b3fdb478bcac243cade43f115abb768b4a
Cr-Commit-Position: refs/heads/master@{#422081}

Powered by Google App Engine
This is Rietveld 408576698