Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Unified Diff: tools/perf/page_sets/system_health/loading_stories.py

Issue 2386083003: Add background stories to MobileSystemHealth (Closed)
Patch Set: fixup stories Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/perf/page_sets/system_health/loading_stories.py
diff --git a/tools/perf/page_sets/system_health/loading_stories.py b/tools/perf/page_sets/system_health/loading_stories.py
index eae99f9b2fbeaf3b4a2f66685b4a1c9402ac815c..2984dcefad15d9dd32fd68a3dfd91ec96c405669 100644
--- a/tools/perf/page_sets/system_health/loading_stories.py
+++ b/tools/perf/page_sets/system_health/loading_stories.py
@@ -291,6 +291,7 @@ class _LoadGmailBaseStory(_LoadingStory):
# navigate to a sub-URL to set up the session and hit the resulting
# redirection loop. Afterwards, we can safely navigate to
# https://mail.google.com.
+ action_runner.tab.WaitForDocumentReadyStateToBeComplete()
perezju 2016/10/06 13:32:42 why do we need this now?
hjd 2016/10/06 15:27:35 Otherwise we never end up seeing the Navigate belo
perezju 2016/10/06 15:32:54 Ok, sounds good. Maybe just double-check after rec
action_runner.Navigate(
'https://mail.google.com/mail/mu/mp/872/trigger_redirection_loop')
action_runner.tab.WaitForDocumentReadyStateToBeComplete()

Powered by Google App Engine
This is Rietveld 408576698