Chromium Code Reviews| OLD | NEW |
|---|---|
| 1 # Copyright 2016 The Chromium Authors. All rights reserved. | 1 # Copyright 2016 The Chromium Authors. All rights reserved. |
| 2 # Use of this source code is governed by a BSD-style license that can be | 2 # Use of this source code is governed by a BSD-style license that can be |
| 3 # found in the LICENSE file. | 3 # found in the LICENSE file. |
| 4 | 4 |
| 5 from page_sets.system_health import platforms | 5 from page_sets.system_health import platforms |
| 6 from page_sets.system_health import system_health_story | 6 from page_sets.system_health import system_health_story |
| 7 | 7 |
| 8 from page_sets.login_helpers import dropbox_login | 8 from page_sets.login_helpers import dropbox_login |
| 9 from page_sets.login_helpers import google_login | 9 from page_sets.login_helpers import google_login |
| 10 | 10 |
| (...skipping 273 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 284 def _Login(self, action_runner): | 284 def _Login(self, action_runner): |
| 285 google_login.LoginGoogleAccount(action_runner, 'googletest', | 285 google_login.LoginGoogleAccount(action_runner, 'googletest', |
| 286 self.credentials_path) | 286 self.credentials_path) |
| 287 | 287 |
| 288 # Navigating to https://mail.google.com immediately leads to an infinite | 288 # Navigating to https://mail.google.com immediately leads to an infinite |
| 289 # redirection loop due to a bug in WPR (see | 289 # redirection loop due to a bug in WPR (see |
| 290 # https://github.com/chromium/web-page-replay/issues/70). We therefore first | 290 # https://github.com/chromium/web-page-replay/issues/70). We therefore first |
| 291 # navigate to a sub-URL to set up the session and hit the resulting | 291 # navigate to a sub-URL to set up the session and hit the resulting |
| 292 # redirection loop. Afterwards, we can safely navigate to | 292 # redirection loop. Afterwards, we can safely navigate to |
| 293 # https://mail.google.com. | 293 # https://mail.google.com. |
| 294 action_runner.tab.WaitForDocumentReadyStateToBeComplete() | |
|
perezju
2016/10/06 13:32:42
why do we need this now?
hjd
2016/10/06 15:27:35
Otherwise we never end up seeing the Navigate belo
perezju
2016/10/06 15:32:54
Ok, sounds good. Maybe just double-check after rec
| |
| 294 action_runner.Navigate( | 295 action_runner.Navigate( |
| 295 'https://mail.google.com/mail/mu/mp/872/trigger_redirection_loop') | 296 'https://mail.google.com/mail/mu/mp/872/trigger_redirection_loop') |
| 296 action_runner.tab.WaitForDocumentReadyStateToBeComplete() | 297 action_runner.tab.WaitForDocumentReadyStateToBeComplete() |
| 297 | 298 |
| 298 | 299 |
| 299 class LoadGmailDesktopStory(_LoadGmailBaseStory): | 300 class LoadGmailDesktopStory(_LoadGmailBaseStory): |
| 300 SUPPORTED_PLATFORMS = platforms.DESKTOP_ONLY | 301 SUPPORTED_PLATFORMS = platforms.DESKTOP_ONLY |
| 301 | 302 |
| 302 def _DidLoadDocument(self, action_runner): | 303 def _DidLoadDocument(self, action_runner): |
| 303 # Wait until the UI loads. | 304 # Wait until the UI loads. |
| (...skipping 85 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 389 NAME = 'load:games:miniclip' | 390 NAME = 'load:games:miniclip' |
| 390 # Using "https://" causes "404 Not Found" during WPR recording. | 391 # Using "https://" causes "404 Not Found" during WPR recording. |
| 391 URL = 'http://www.miniclip.com/games/en/' | 392 URL = 'http://www.miniclip.com/games/en/' |
| 392 SUPPORTED_PLATFORMS = platforms.DESKTOP_ONLY # Requires Flash. | 393 SUPPORTED_PLATFORMS = platforms.DESKTOP_ONLY # Requires Flash. |
| 393 | 394 |
| 394 | 395 |
| 395 class LoadAlphabettyStory(_LoadingStory): | 396 class LoadAlphabettyStory(_LoadingStory): |
| 396 NAME = 'load:games:alphabetty' | 397 NAME = 'load:games:alphabetty' |
| 397 URL = 'https://king.com/play/alphabetty' | 398 URL = 'https://king.com/play/alphabetty' |
| 398 SUPPORTED_PLATFORMS = platforms.DESKTOP_ONLY # Requires Flash. | 399 SUPPORTED_PLATFORMS = platforms.DESKTOP_ONLY # Requires Flash. |
| OLD | NEW |