Prune createVisibleSelectionDeprecated from FrameSelection

Prune createVisibleSelectionDeprecated from FrameSelection

BUG=651373
Committed: https://crrev.com/d1d59d936e6de0bdf43fc8fac4b191e2c152354d
Cr-Commit-Position: refs/heads/master@{#422667}

[Xiaocheng, 2016-10-03 08:50:34]

The CQ bit was checked by xiaochengh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-03 08:50:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-03 10:03:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-03 10:03:48]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Xiaocheng, 2016-10-03 16:09:20]

The CQ bit was checked by xiaochengh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-03 16:09:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-03 19:08:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-03 19:08:55]

Dry run: This issue passed the CQ dry run.

[Xiaocheng, 2016-10-04 01:01:39]

xiaochengh@chromium.org changed reviewers:
+ yosin@chromium.org

[Xiaocheng, 2016-10-04 01:01:40]

PTAL.

https://codereview.chromium.org/2386073003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/editing/DOMSelection.cpp (right):

https://codereview.chromium.org/2386073003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/editing/DOMSelection.cpp:466:
frame()->document()->updateStyleAndLayoutIgnorePendingStylesheets();
Originally, DOMSelection::addRange doesn't trigger layout if it fails. This
patch makes layout triggered in more cases. Do we mind that?

[yosin_UTC9, 2016-10-04 01:52:05]

The CQ bit was checked by yosin@chromium.org

[yosin_UTC9, 2016-10-04 01:52:06]

lgtm

https://codereview.chromium.org/2386073003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/editing/DOMSelection.cpp (right):

https://codereview.chromium.org/2386073003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/editing/DOMSelection.cpp:466:
frame()->document()->updateStyleAndLayoutIgnorePendingStylesheets();
On 2016/10/04 at 01:01:40, Xiaocheng wrote:
> Originally, DOMSelection::addRange doesn't trigger layout if it fails. This
patch makes layout triggered in more cases. Do we mind that?

Upon failure, we don't grantee state. So, it should be OK to update layout tree.

[commit-bot: I haz the power, 2016-10-04 01:52:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-04 02:00:43]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-10-04 02:02:42]

Description was changed from

==========
Prune createVisibleSelectionDeprecated from FrameSelection

BUG=651373
==========

to

==========
Prune createVisibleSelectionDeprecated from FrameSelection

BUG=651373

Committed: https://crrev.com/d1d59d936e6de0bdf43fc8fac4b191e2c152354d
Cr-Commit-Position: refs/heads/master@{#422667}
==========

[commit-bot: I haz the power, 2016-10-04 02:02:43]

Patchset 2 (id:??) landed as
https://crrev.com/d1d59d936e6de0bdf43fc8fac4b191e2c152354d
Cr-Commit-Position: refs/heads/master@{#422667}